Attempted fix for initial load issue. #47
Conversation
All parts of the guard statement have been split into let statements and two separate if statements. If localStoredData == nil we still want to synchronize.
| return | ||
| } | ||
|
|
||
| if (localStoredDate != nil && remoteStoredDate != nil && !(remoteStoredDate!.timeIntervalSince1970 > localStoredDate!.timeIntervalSince1970)) { |
There was a problem hiding this comment.
these are force-unwrapped. Mind addressing that? Thank you!
There was a problem hiding this comment.
Absolutely. Have added extra check and avoid force-unwrapping.
There was a problem hiding this comment.
localStoredDate! is still force unwrapped :)
There was a problem hiding this comment.
My bad, damn typos... Anyway, now it should actually be fixed ;)
There was a problem hiding this comment.
Thanks - will check it out this weekend
There was a problem hiding this comment.
We have force-unwrapping here again, see comment below.
|
This does not compile in Xcode 11.5. A couple errors around optionals. |
|
The force-unwrapping of the optionals is necessary to avoid Xcode throwing a fit. Given that a nil check has already been done the code that force-unwraps is not reachable with a nil value, thus never throwing an error. To me this seems the best way to use the optional values here. Do you have a suggestion for a better way to approach this? Thanks in advance! |
|
I'll fix the force-unwrap issue once I compile and test your code in a branch of mine. Thanks! |
|
Thanks! And thanks again for the whole project, awesome piece of code :) |
|
Thank you! I appreciate that! |
|
Alright, tested it in a person project - worked well. Will merge your stuff then overwrite with a cleaner implementation that has no force-uwnraps. Thanks again! |
|
Here's the release notes: https://github.com/ArtSabintsev/Zephyr/releases/tag/3.6.0 It should be available across all dependency managers now. |
|
No problem, glad to be able to help. Thank you for the kind mention in the release notes! |
All parts of the guard statement have been split into let statements and two separate if statements.
If
localStoredData == nilwe still want to synchronize.See issue #48.