fix(ui/lifecycle): keep root element during destroy (#810)

ArtalkJS · Apr 2, 2024 · de5e1b4 · de5e1b4
1 parent b60cb58
commit de5e1b4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/ui/artalk/src/artalk.ts b/ui/artalk/src/artalk.ts
@@ -59,7 +59,9 @@ export default class Artalk {
   /** Destroy instance of Artalk */
   public destroy() {
     this.ctx.trigger('unmounted')
-    this.ctx.$root.remove()
+    while (this.ctx.$root.firstChild) {
+      this.ctx.$root.removeChild(this.ctx.$root.firstChild)
+    }
   }
 
   /** Add an event listener */

diff --git a/ui/artalk/tests/ui-api.test.ts b/ui/artalk/tests/ui-api.test.ts
@@ -158,10 +158,7 @@ describe('Artalk instance', () => {
     artalk.destroy()
 
     // detect if it is cleaned up
-    const selectors = [`#${ContainerID}`, '.atk-layer-wrap']
-    selectors.forEach(selector => {
-      const el = document.querySelector(selector)
-      expect(el).toBe(null)
-    })
+    expect(document.querySelector(`#${ContainerID}`)?.firstChild).toBe(null)
+    expect(document.querySelector('.atk-layer-wrap')).toBe(null)
   })
 })