-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nik karasyov exam 7 #8
base: main
Are you sure you want to change the base?
Conversation
Design Initial
Revert "Design Initial"
added uml charts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Правьте замечания и сливайте в main
double &scale; | ||
std::pair<int, int> &size; | ||
public: | ||
SecondDimensionDecartDrawer(auto *f, double &scale, std::pair<int, int> &size); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
вы шаблонный конструктор объявили, может f можно как-то ограничить
class SecondDimensionDecartDrawer: SecondDimensionDrawer{ | ||
private: | ||
double &scale; | ||
std::pair<int, int> &size; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
храните по значению, не такая большая структура
#pragma once | ||
class PolarDrawer: SecondDimensionDrawer{ | ||
private: | ||
double **values; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::vector
private: | ||
double **values; | ||
public: | ||
virtual Drawer(double **parsed_data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
виртуальный конструктор не имеет смысла. У вас в любом случае при создании объекта вызывается его конструктор, затем все конструкторы всех родителей
Gnuplot gp; | ||
|
||
std::vector<boost::tuple<double, double> > graph; | ||
double left_border = this->size.first * -1 / 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
писать this-> не нужно
int main() { | ||
Gnuplot gp; | ||
|
||
std::vector<boost::tuple<double, double, double, double> > pts_A; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tuple есть в std
No description provided.