Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hook search problem #174

Closed
Raikuya opened this issue Jul 14, 2019 · 10 comments
Closed

hook search problem #174

Raikuya opened this issue Jul 14, 2019 · 10 comments

Comments

@Raikuya
Copy link

Raikuya commented Jul 14, 2019

So. . . I know that using the hook search may result in the game crashing and I'm fully aware of that while making this but when I try to search hook the VN, well, it does finish searching, and it even says it found the hooks it was looking for but when I looked at the file location for the hook text file, it isn't there.

So I did a bunch of test to see what's going on and I found out that it seems that you really need to continue pressing next with VN during the search for the hook text file to appear but the problem is that if I press next in the VN during the search, it crashes and gives me an incomplete hook text file with just a few non readable hooks but if I don't press next in the VN, then it says that it has completed the search and found the hooks but there is no hook text file in the file location (the one in the picture). Any tips on how this can be solved? Thanks.

Screenshot (135)

@Artikash
Copy link
Owner

Artikash commented Jul 15, 2019

Oh yeah, hook searching pretty much doesn't work on ShinaRio engine (which nukitashi uses) due to its antihacking protection and there's not much way to fix that.
Does nukitashi not get hooked correctly by default? It should work without needing a custom hook.

@Raikuya
Copy link
Author

Raikuya commented Jul 15, 2019

It has this one h code which works perfectly but I can only see it on rare occasions, it being this 2E:1BB8:44V4DC0:0:0: READ (RS@44B4DC0), there is another one that works but it outputs the dialogues twice which is annoying on long dialogues.

@Artikash
Copy link
Owner

Oh, so it does work occasionally? Then I think I know the problem. Try restarting nukitashi and after loading back in to where you were immediately attach Textractor.

@Raikuya
Copy link
Author

Raikuya commented Jul 15, 2019

It seems to only show up if you attach the textractor in certain parts of the vn.

@Artikash
Copy link
Owner

Artikash commented Jul 15, 2019

To confirm, did you try restarting nukitashi?
Did you still get the "inserting hook: READ" message in the times where it doesn't find the perfect h code?

@Raikuya
Copy link
Author

Raikuya commented Jul 15, 2019

I didn't need to restart, just loaded to some parts in the vn and attached textractor but if don't go to that certain part, it's still inserting hook: READ but the right one isn't there.

@Artikash
Copy link
Owner

Sigh.
Time to install and try to debug this...for the fourth? time.
What OS are you on?
Does the Stext hooking method shown at ~0:55 in the tutorial video work consistently?
Lastly, you mentioned that there's another hook that outputs twice, have you tried the 'Remove Repeated Phrase' extension and is it able to remove the extra output correctly? If not, could you post what the output of that hook is?

@Raikuya
Copy link
Author

Raikuya commented Jul 16, 2019

I'm on windows 10.
The one with the drop down auto searched codes? Well, yeah, if you say that hooking some parts of the sentences works, then it works.
Yes, the Remove Repeated Phrase extension is there. The hook I was talking about was the one you made for Nukitashi which is this HS4C@0:gdi32.dll:GetTextExtentPoint32A
Screenshot (136)

I had the output in sent to TA which reads from the clipboard and yes, the dialogues are outputted twice.

@Artikash
Copy link
Owner

Artikash commented Jul 16, 2019

For now, use the regex filter 」「[^]+.

@Artikash
Copy link
Owner

Should be fixed in 4.5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants