Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow checkout branch from private fork #394

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

ddlan
Copy link
Contributor

@ddlan ddlan commented Sep 20, 2023

This PR fixes #393.

If git checkout by ref.ref fails, try git checkout by ref.sha since the PR head commit is available in the base repo.

This can be tested by creating a private repo with the github action, making a fork, and making a PR from the fork.

I've added an unit test accordingly.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
95.44% (+0.01% 🔼)
837/877
🟢 Branches 88.77% 419/472
🟢 Functions 93.64% 162/173
🟢 Lines
95.07% (+0.01% 🔼)
752/791

Test suite run success

167 tests passing in 57 suites.

Report generated by 🧪jest coverage report action from 1573178

@ArtiomTr
Copy link
Owner

Hey @ddlan 👋,

Thank you for your contribution! Could you please fix the linting issues?

@ddlan
Copy link
Contributor Author

ddlan commented Sep 22, 2023

Fixed!

@ArtiomTr ArtiomTr merged commit 5677857 into ArtiomTr:main Sep 22, 2023
7 checks passed
@ArtiomTr
Copy link
Owner

Thank you! Your fix is available under v2.2.5 (or just v2) tag.

@all-contributors please add @ddlan for code

@allcontributors
Copy link
Contributor

@ArtiomTr

I've put up a pull request to add @ddlan! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot checkout branch from private fork
2 participants