Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certificate-folder #31

Merged
merged 2 commits into from
Oct 2, 2023
Merged

certificate-folder #31

merged 2 commits into from
Oct 2, 2023

Conversation

hollermay
Copy link
Contributor

added 6 certificate template files with added guides and resolves the issue number #16

added certificate files
@Artlfmj
Copy link
Owner

Artlfmj commented Oct 2, 2023

It's good by I don't want it to close the issue as other templates are always good to get. Also your templates, can you remove the your name easily?

@hollermay
Copy link
Contributor Author

It's good by I don't want it to close the issue as other templates are always good to get. Also your templates, can you remove the your name easily?

Yeah I can

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 2, 2023

Is it already able to change easily or do you need to commit?

@hollermay
Copy link
Contributor Author

Is it already able to change easily or do you need to commit?

I'll have to commit lol, but if you have a pdf editor you can remove that from your end too

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 2, 2023

Please commit

Copy link
Owner

@Artlfmj Artlfmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove your name

@hollermay
Copy link
Contributor Author

your mean the [name] part right?

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 2, 2023

Yes

@hollermay
Copy link
Contributor Author

@Artlfmj I have pushed changes into the branch please review

@hollermay hollermay requested a review from Artlfmj October 2, 2023 11:08
@Artlfmj
Copy link
Owner

Artlfmj commented Oct 2, 2023

Merging, if you want to work on new stuff you are more than welcome to :)

@Artlfmj Artlfmj merged commit b9a090c into Artlfmj:main Oct 2, 2023
3 checks passed
@hollermay
Copy link
Contributor Author

Merging, if you want to work on new stuff you are more than welcome to :)

Yeah sure you can add hacktoberfest-accepted to close the issue or I'll keep adding 2-3 new templates here

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 2, 2023

The whole repo has hacktoberfest topic so it should count, please check. If not I will add it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants