Moves Timecop to development dependency, Issue #55 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_time method when Timecop is available, but in other cases uses Time.raw_now method.
|
@rdalin82 Thanks for PR. I've released a new knapsack version. |
|
@ArturT Thanks for maintaining an easy to contribute to project. Cheers! |
|
@rdalin82 I'm curious, how you found out about it? Is it because of tag |
|
@ArturT yes it was I did this as a search: label:first-timers-only language:ruby is:open no:assignee |
|
Good to know that |
|
It does! lots of articles are starting to reference it, I'm thinking about doing my own medium article about my experience. |
|
Oh, that's cool. Please let me know if you publish something. Do you have a twitter account so I could follow you? |
|
I'm not on twitter at the moment, but I'll let you know if that changes in the future. I'll send you a message if I do publish. |
|
Awesome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #55
Moves Timecop to development dependency
Use Timecop now_without_mock_time method when Timecop available. In
other case use the Time.raw_now method