Skip to content

Commit

Permalink
cifs: rename fs/cifs directory to fs/smbfs_client
Browse files Browse the repository at this point in the history
To be more consistent with the source directory name for the
new smb3 server (ksmbd), and to avoid using the word "cifs"
(a very old dialect) when more recent dialects (like SMB3 or
SMB3.1.1) are meant, rename the client directory from
fs/cifs to fs/smbfs_client. It is already possible to do
"modprobe smb3" or "mount -t smb3 ..."

Note that this does not rename the module itself (cifs.ko)
although that could be done in a future patch.

Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
  • Loading branch information
Steve French committed Sep 14, 2021
1 parent 4c51de1 commit b4a8c8f
Show file tree
Hide file tree
Showing 81 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion Documentation/admin-guide/cifs/changes.rst
Expand Up @@ -5,5 +5,5 @@ Changes
See https://wiki.samba.org/index.php/LinuxCIFSKernel for summary
information about fixes/improvements to CIFS/SMB2/SMB3 support (changes
to cifs.ko module) by kernel version (and cifs internal module version).
This may be easier to read than parsing the output of "git log fs/cifs"
This may be easier to read than parsing the output of "git log fs/smbfs_client"
by release.
14 changes: 7 additions & 7 deletions Documentation/admin-guide/cifs/usage.rst
Expand Up @@ -45,7 +45,7 @@ Installation instructions

If you have built the CIFS vfs as module (successfully) simply
type ``make modules_install`` (or if you prefer, manually copy the file to
the modules directory e.g. /lib/modules/2.4.10-4GB/kernel/fs/cifs/cifs.ko).
the modules directory e.g. /lib/modules/5.10.0+/kernel/fs/smbfs_client/cifs.ko).

If you have built the CIFS vfs into the kernel itself, follow the instructions
for your distribution on how to install a new kernel (usually you
Expand All @@ -66,22 +66,22 @@ If cifs is built as a module, then the size and number of network buffers
and maximum number of simultaneous requests to one server can be configured.
Changing these from their defaults is not recommended. By executing modinfo::

modinfo kernel/fs/cifs/cifs.ko
modinfo kernel/fs/smbfs_client/cifs.ko

on kernel/fs/cifs/cifs.ko the list of configuration changes that can be made
at module initialization time (by running insmod cifs.ko) can be seen.
on kernel/fs/smbfs_client/cifs.ko the list of configuration changes that can be
made at module initialization time (by running insmod cifs.ko) can be seen.

Recommendations
===============

To improve security the SMB2.1 dialect or later (usually will get SMB3) is now
the new default. To use old dialects (e.g. to mount Windows XP) use "vers=1.0"
To improve security the SMB2.1 dialect or later (usually will get SMB3.1.1) is
now the default. To use old dialects (e.g. to mount Windows XP) use "vers=1.0"
on mount (or vers=2.0 for Windows Vista). Note that the CIFS (vers=1.0) is
much older and less secure than the default dialect SMB3 which includes
many advanced security features such as downgrade attack detection
and encrypted shares and stronger signing and authentication algorithms.
There are additional mount options that may be helpful for SMB3 to get
improved POSIX behavior (NB: can use vers=3.0 to force only SMB3, never 2.1):
improved POSIX behavior (NB: can use vers=3 to force only SMB3, never 2.1):

``mfsymlinks`` and either ``cifsacl`` or ``modefromsid`` (usually with ``idsfromsid``)

Expand Down
2 changes: 1 addition & 1 deletion Documentation/filesystems/cifs/cifsroot.rst
Expand Up @@ -59,7 +59,7 @@ the root file system via SMB protocol.
Enables the kernel to mount the root file system via SMB that are
located in the <server-ip> and <share> specified in this option.

The default mount options are set in fs/cifs/cifsroot.c.
The default mount options are set in fs/smbfs_client/cifsroot.c.

server-ip
IPv4 address of the server.
Expand Down
2 changes: 1 addition & 1 deletion Documentation/userspace-api/ioctl/ioctl-number.rst
Expand Up @@ -359,7 +359,7 @@ Code Seq# Include File Comments
0xCC 00-0F drivers/misc/ibmvmc.h pseries VMC driver
0xCD 01 linux/reiserfs_fs.h
0xCE 01-02 uapi/linux/cxl_mem.h Compute Express Link Memory Devices
0xCF 02 fs/cifs/ioctl.c
0xCF 02 fs/smbfs_client/ioctl.c
0xDB 00-0F drivers/char/mwave/mwavepub.h
0xDD 00-3F ZFCP device driver see drivers/s390/scsi/
<mailto:aherrman@de.ibm.com>
Expand Down
4 changes: 2 additions & 2 deletions MAINTAINERS
Expand Up @@ -4655,8 +4655,8 @@ S: Supported
W: http://linux-cifs.samba.org/
T: git git://git.samba.org/sfrench/cifs-2.6.git
F: Documentation/admin-guide/cifs/
F: fs/cifs/
F: fs/cifs_common/
F: fs/smbfs_client/
F: fs/smbfs_common/

COMPACTPCI HOTPLUG CORE
M: Scott Murray <scott@spiteful.org>
Expand Down
2 changes: 1 addition & 1 deletion fs/Kconfig
Expand Up @@ -364,7 +364,7 @@ config NFS_V4_2_SSC_HELPER
source "net/sunrpc/Kconfig"
source "fs/ceph/Kconfig"

source "fs/cifs/Kconfig"
source "fs/smbfs_client/Kconfig"
source "fs/ksmbd/Kconfig"

config SMBFS_COMMON
Expand Down
2 changes: 1 addition & 1 deletion fs/Makefile
Expand Up @@ -97,7 +97,7 @@ obj-$(CONFIG_NLS) += nls/
obj-$(CONFIG_UNICODE) += unicode/
obj-$(CONFIG_SYSV_FS) += sysv/
obj-$(CONFIG_SMBFS_COMMON) += smbfs_common/
obj-$(CONFIG_CIFS) += cifs/
obj-$(CONFIG_CIFS) += smbfs_client/
obj-$(CONFIG_SMB_SERVER) += ksmbd/
obj-$(CONFIG_HPFS_FS) += hpfs/
obj-$(CONFIG_NTFS_FS) += ntfs/
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit b4a8c8f

Please sign in to comment.