Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KVM enabled? #26

Closed
kyr0 opened this issue Apr 5, 2022 · 4 comments
Closed

KVM enabled? #26

kyr0 opened this issue Apr 5, 2022 · 4 comments

Comments

@kyr0
Copy link

kyr0 commented Apr 5, 2022 •
edited

Do I see it correctly that KVM is enabled?

https://github.com/AsahiLinux/linux/blob/asahi/arch/arm64/configs/defconfig#L110

Or is this configuration overwritten somewhere?

Sry, I'm a bit out of kernel stuff since a few years. Need some time to get back to this business

Because if that works and qemu compiles and runs well (yeah, yeah, the 16k page size fun), we'd be able to run KVM acceleration enabled qemu on an M1?

https://community.arm.com/oss-platforms/w/docs/510/spawn-a-linux-virtual-machine-on-arm-using-qemu-kvm
@jannau
Copy link
Member

jannau commented Apr 6, 2022

Please do not use github issues as discussion forum.

qemu with kvm works well out of the box on M1 Pro/Max/Ultra. On the original M1 it needs an unreleased qemu version to work well out of the box. It work afaik with higmem=off 16k page size is not a problem for qemu.

@kyr0
Copy link
Author

kyr0 commented Apr 6, 2022 •
edited

You're right, thank you. On top of that (I tested and verified it yesterday night), it runs SerenityOS without any problems.
However KVM support wasn't working by default but I guess that is out of scope here as it is an issue about what qemu system binary to use in regards to pure ARM KVM support.

Leaving it here for reference for whenever someone has the same "issue": https://community.arm.com/oss-platforms/w/docs/510/spawn-a-linux-virtual-machine-on-arm-using-qemu-kvm

I'll probably fix/PR the issue for SerenityOS (guest) so that it makes use of KVM functionality when running on Ashai (host); specifically if/else case needs to be added for using qemu-system-aarch64 with qemu on Ashai; https://github.com/SerenityOS/serenity/blob/master/Meta/run.sh#L38

I'll just report back tonight if that worked but it's fine if we close this issue right now. Thank you

@pimpmypicture
Copy link

Regarding initial question, qemu 7.0 brought compatibility with KVM on original M1.

Alas, a bug was found when enabling smp (https://gitlab.com/qemu-project/qemu/-/issues/1002).
There is a workaround but you must compile qemu yourself (and revert a specific commit).

@pbo-linaro
Copy link

Regarding previous message, is seems like KVM currently does not support a cpu having two different kind of cores (like M1).
Full details: https://gitlab.com/qemu-project/qemu/-/issues/1002#note_933186950

So reverting the commit on qemu does not really solve the original problem (only a part of it).

asahilina pushed a commit that referenced this issue Aug 17, 2022
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
8d2ddae 
t8103:
- WLAN (SMC PMU GPIO #13)
t600x:
- WLAN (SMC PMU GPIO #13)
- SD (SMC PMU GPIO #26)

Signed-off-by: Hector Martin <marcan@marcan.st>
asahilina pushed a commit that referenced this issue Aug 17, 2022
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
e1a42fe 
t8103:
- WLAN (SMC PMU GPIO #13)
t600x:
- WLAN (SMC PMU GPIO #13)
- SD (SMC PMU GPIO #26)

Signed-off-by: Hector Martin <marcan@marcan.st>
@marcan marcan closed this as completed Sep 9, 2022
marcan added a commit that referenced this issue Sep 12, 2022
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
a744c9c 
t8103:
- WLAN (SMC PMU GPIO #13)
t600x:
- WLAN (SMC PMU GPIO #13)
- SD (SMC PMU GPIO #26)

Signed-off-by: Hector Martin <marcan@marcan.st>
marcan added a commit that referenced this issue Sep 12, 2022
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
16d4644 
t8103:
- WLAN (SMC PMU GPIO #13)
t600x:
- WLAN (SMC PMU GPIO #13)
- SD (SMC PMU GPIO #26)

Signed-off-by: Hector Martin <marcan@marcan.st>
chadmed pushed a commit to chadmed/linux that referenced this issue Oct 27, 2022
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
cf9890b 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
chadmed pushed a commit to chadmed/linux that referenced this issue Oct 27, 2022
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
65c1bf1 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
WhatAmISupposedToPutHere pushed a commit to WhatAmISupposedToPutHere/linux that referenced this issue Nov 4, 2022
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
40d6465 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
chadmed pushed a commit to chadmed/linux that referenced this issue Nov 27, 2022
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
da5cb9f 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
chadmed pushed a commit to chadmed/linux that referenced this issue Nov 27, 2022
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
a979349 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
marcan added a commit that referenced this issue Nov 28, 2022
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
63942b8 
t8103:
- WLAN (SMC PMU GPIO #13)
t600x:
- WLAN (SMC PMU GPIO #13)
- SD (SMC PMU GPIO #26)

Signed-off-by: Hector Martin <marcan@marcan.st>
marcan added a commit that referenced this issue Nov 28, 2022
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
2f4a334 
t8103:
- WLAN (SMC PMU GPIO #13)
t600x:
- WLAN (SMC PMU GPIO #13)
- SD (SMC PMU GPIO #26)

Signed-off-by: Hector Martin <marcan@marcan.st>
chadmed pushed a commit to chadmed/linux that referenced this issue Dec 9, 2022
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
d34df6f 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
chadmed pushed a commit to chadmed/linux that referenced this issue Dec 9, 2022
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
80d042c 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
chadmed pushed a commit to chadmed/linux that referenced this issue Dec 16, 2022
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
2538e82 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
chadmed pushed a commit to chadmed/linux that referenced this issue Dec 16, 2022
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
efb45e7 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
WhatAmISupposedToPutHere pushed a commit to WhatAmISupposedToPutHere/linux that referenced this issue Jan 15, 2023
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
59dab01 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
WhatAmISupposedToPutHere pushed a commit to WhatAmISupposedToPutHere/linux that referenced this issue Jan 15, 2023
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
bc9c599 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
asahilina pushed a commit that referenced this issue Feb 15, 2023
@krzk @gregkh
tty: serial: qcom-geni-serial: fix slab-out-of-bounds on RX FIFO buffer
b8caf69 
Driver's probe allocates memory for RX FIFO (port->rx_fifo) based on
default RX FIFO depth, e.g. 16.  Later during serial startup the
qcom_geni_serial_port_setup() updates the RX FIFO depth
(port->rx_fifo_depth) to match real device capabilities, e.g. to 32.

The RX UART handle code will read "port->rx_fifo_depth" number of words
into "port->rx_fifo" buffer, thus exceeding the bounds.  This can be
observed in certain configurations with Qualcomm Bluetooth HCI UART
device and KASAN:

  Bluetooth: hci0: QCA Product ID   :0x00000010
  Bluetooth: hci0: QCA SOC Version  :0x400a0200
  Bluetooth: hci0: QCA ROM Version  :0x00000200
  Bluetooth: hci0: QCA Patch Version:0x00000d2b
  Bluetooth: hci0: QCA controller version 0x02000200
  Bluetooth: hci0: QCA Downloading qca/htbtfw20.tlv
  bluetooth hci0: Direct firmware load for qca/htbtfw20.tlv failed with error -2
  Bluetooth: hci0: QCA Failed to request file: qca/htbtfw20.tlv (-2)
  Bluetooth: hci0: QCA Failed to download patch (-2)
  ==================================================================
  BUG: KASAN: slab-out-of-bounds in handle_rx_uart+0xa8/0x18c
  Write of size 4 at addr ffff279347d578c0 by task swapper/0/0

  CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.1.0-rt5-00350-gb2450b7e00be-dirty #26
  Hardware name: Qualcomm Technologies, Inc. Robotics RB5 (DT)
  Call trace:
   dump_backtrace.part.0+0xe0/0xf0
   show_stack+0x18/0x40
   dump_stack_lvl+0x8c/0xb8
   print_report+0x188/0x488
   kasan_report+0xb4/0x100
   __asan_store4+0x80/0xa4
   handle_rx_uart+0xa8/0x18c
   qcom_geni_serial_handle_rx+0x84/0x9c
   qcom_geni_serial_isr+0x24c/0x760
   __handle_irq_event_percpu+0x108/0x500
   handle_irq_event+0x6c/0x110
   handle_fasteoi_irq+0x138/0x2cc
   generic_handle_domain_irq+0x48/0x64

If the RX FIFO depth changes after probe, be sure to resize the buffer.

Fixes: f9d690b ("tty: serial: qcom_geni_serial: Allocate port->rx_fifo buffer in probe")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20221221164022.1087814-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
marcan added a commit that referenced this issue Apr 24, 2023
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
8ed1721 
t8103:
- WLAN (SMC PMU GPIO #13)
t600x:
- WLAN (SMC PMU GPIO #13)
- SD (SMC PMU GPIO #26)

Signed-off-by: Hector Martin <marcan@marcan.st>
marcan added a commit that referenced this issue Apr 24, 2023
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
a7eb61c 
t8103:
- WLAN (SMC PMU GPIO #13)
t600x:
- WLAN (SMC PMU GPIO #13)
- SD (SMC PMU GPIO #26)

Signed-off-by: Hector Martin <marcan@marcan.st>
WhatAmISupposedToPutHere pushed a commit to WhatAmISupposedToPutHere/linux that referenced this issue Apr 24, 2023
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
b9f8e92 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
WhatAmISupposedToPutHere pushed a commit to WhatAmISupposedToPutHere/linux that referenced this issue Apr 24, 2023
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
77134f6 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
chadmed pushed a commit to chadmed/linux that referenced this issue Apr 29, 2023
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
5551408 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
chadmed pushed a commit to chadmed/linux that referenced this issue Apr 29, 2023
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
9088d67 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Oct 9, 2023
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
2f1ceba 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Oct 9, 2023
@marcan
arm64: dts: apple: Add PCI power enable GPIOs
b1c6476 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Oct 27, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
79bc121 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Oct 27, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
20804f4 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Oct 29, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
ed153a4 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Oct 29, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
f0e3f31 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Oct 30, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
f2211ac 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Oct 30, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
93c44c3 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Nov 8, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
c133a60 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Nov 8, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
37b5eff 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Nov 12, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
9f569ec 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Nov 12, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
0533a7c 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Nov 12, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
6e1b0c2 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Nov 12, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
c1eea24 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Nov 18, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
93d99cf 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Nov 18, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
19c43b5 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Nov 20, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
6abae5f 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Nov 20, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
24bf361 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Nov 23, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
0799826 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
dberlin pushed a commit to dberlin/linux that referenced this issue Nov 23, 2023
@marcan @dberlin
arm64: dts: apple: Add PCI power enable GPIOs
67602b1 
t8103:
- WLAN (SMC PMU GPIO AsahiLinux#13)
t600x:
- WLAN (SMC PMU GPIO AsahiLinux#13)
- SD (SMC PMU GPIO AsahiLinux#26)

Signed-off-by: Hector Martin <marcan@marcan.st>
marcan pushed a commit that referenced this issue Jan 19, 2024
@davem330
net: dsa: mv88e6xxx: fix marvell 6350 probe crash
a524eab 
As of commit b92143d ("net: dsa: mv88e6xxx: add infrastructure for
phylink_pcs") probing of a Marvell 88e6350 switch causes a NULL pointer
de-reference like this example:

    ...
    mv88e6085 d0072004.mdio-mii:11: switch 0x3710 detected: Marvell 88E6350, revision 2
    8<--- cut here ---
    Unable to handle kernel NULL pointer dereference at virtual address 00000000 when read
    [00000000] *pgd=00000000
    Internal error: Oops: 5 [#1] ARM
    Modules linked in:
    CPU: 0 PID: 8 Comm: kworker/u2:0 Not tainted 6.7.0-rc2-dirty #26
    Hardware name: Marvell Armada 370/XP (Device Tree)
    Workqueue: events_unbound deferred_probe_work_func
    PC is at mv88e6xxx_port_setup+0x1c/0x44
    LR is at dsa_port_devlink_setup+0x74/0x154
    pc : [<c057ea24>]    lr : [<c0819598>]    psr: a0000013
    sp : c184fce0  ip : c542b8f4  fp : 00000000
    r10: 00000001  r9 : c542a540  r8 : c542bc00
    r7 : c542b838  r6 : c5244580  r5 : 00000005  r4 : c5244580
    r3 : 00000000  r2 : c542b840  r1 : 00000005  r0 : c1a02040
    ...

The Marvell 6350 switch has no SERDES interface and so has no
corresponding pcs_ops defined for it. But during probing a call is made
to mv88e6xxx_port_setup() which unconditionally expects pcs_ops to exist -
though the presence of the pcs_ops->pcs_init function is optional.

Modify code to check for pcs_ops first, before checking for and calling
pcs_ops->pcs_init. Modify checking and use of pcs_ops->pcs_teardown
which may potentially suffer the same problem.

Fixes: b92143d ("net: dsa: mv88e6xxx: add infrastructure for phylink_pcs")
Signed-off-by: Greg Ungerer <gerg@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
svenpeter42 pushed a commit that referenced this issue Apr 17, 2024
@marcan @jannau
arm64: dts: apple: Add PCI power enable GPIOs
d43e231 
t8103:
- WLAN (SMC PMU GPIO #13)
t600x:
- WLAN (SMC PMU GPIO #13)
- SD (SMC PMU GPIO #26)

Signed-off-by: Hector Martin <marcan@marcan.st>
svenpeter42 pushed a commit that referenced this issue Apr 17, 2024
@marcan @jannau
arm64: dts: apple: Add PCI power enable GPIOs
4cee22f 
t8103:
- WLAN (SMC PMU GPIO #13)
t600x:
- WLAN (SMC PMU GPIO #13)
- SD (SMC PMU GPIO #26)

Signed-off-by: Hector Martin <marcan@marcan.st>
jannau pushed a commit that referenced this issue Apr 29, 2024
@marcan @jannau
arm64: dts: apple: Add PCI power enable GPIOs
868dda9 
t8103:
- WLAN (SMC PMU GPIO #13)
t600x:
- WLAN (SMC PMU GPIO #13)
- SD (SMC PMU GPIO #26)

Signed-off-by: Hector Martin <marcan@marcan.st>
jannau pushed a commit that referenced this issue Apr 29, 2024
@marcan @jannau
arm64: dts: apple: Add PCI power enable GPIOs
095c7f4 
t8103:
- WLAN (SMC PMU GPIO #13)
t600x:
- WLAN (SMC PMU GPIO #13)
- SD (SMC PMU GPIO #26)

Signed-off-by: Hector Martin <marcan@marcan.st>
jannau pushed a commit that referenced this issue Jun 4, 2024
@marcan @jannau
arm64: dts: apple: Add PCI power enable GPIOs
1e66aa8 
t8103:
- WLAN (SMC PMU GPIO #13)
t600x:
- WLAN (SMC PMU GPIO #13)
- SD (SMC PMU GPIO #26)

Signed-off-by: Hector Martin <marcan@marcan.st>
jannau pushed a commit that referenced this issue Jun 4, 2024
@marcan @jannau
arm64: dts: apple: Add PCI power enable GPIOs
0156270 
t8103:
- WLAN (SMC PMU GPIO #13)
t600x:
- WLAN (SMC PMU GPIO #13)
- SD (SMC PMU GPIO #26)

Signed-off-by: Hector Martin <marcan@marcan.st>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@marcan @kyr0 @jannau @pimpmypicture @pbo-linaro