DCP updates 2022-12-11 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jannau
commented
Dec 11, 2022
jannau
commented
- improved color mode parsing, reject HDR color modes, should fix color representation in some cases
- color/timing mode tracing, to help debug mode/color related issues
- re-add support for ARGB2101010
- firmware (compat) version check fix
- add module parameter to show the full display height on macbooks with notch
Make the version check less stupid, only check the compat version and parse the actual version just to report it in error cases. Signed-off-by: Janne Grunau <j@jannau.net>
Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Janne Grunau <j@jannau.net>
Selecting the mode with the highest score may result in HDR mode for some displays. Since HDR is not support on driver side this produces an unexpected color representation. Full parsing allows us to reject virtual color modes (should already be invalid due to missing "Score"). Preparation for color and timing mode tracing. Signed-off-by: Janne Grunau <j@jannau.net>
Prevents trace points of unused color modes. Signed-off-by: Janne Grunau <j@jannau.net>
Restrict symbol mapping for EOTF, pixel encoding and colorimetry to tracing due to low confidence that it is correct. Main concern is the colorimetry mapping. Signed-off-by: Janne Grunau <j@jannau.net>
DCP best scored color mode might result in an HDR mode. As long as the driver (and DRM) is not ready for HDR try to avoid such modes. Signed-off-by: Janne Grunau <j@jannau.net>
Probably not important but avoids an unnecessary difference compred to macOS. Signed-off-by: Janne Grunau <j@jannau.net>
Seems to work now with 'surface.colorspace = 12'. Signed-off-by: Janne Grunau <j@jannau.net>
Can be used on devices with camera notch to use the full display height and thus show the notch. Signed-off-by: Janne Grunau <j@jannau.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.