Use dcpext for all M2 desktop devices. #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same value as the arm64 kernel build uses. Avoids following warning: | src/tinf/tinflate.c: In function ‘tinf_uncompress’: | src/tinf/tinflate.c:559:5: warning: stack usage is 1712 bytes [-Wstack-usage=] | 559 | int tinf_uncompress(void *dest, unsigned int *destLen, Signed-off-by: Janne Grunau <j@jannau.net>
Required for stage 1 loader to allow chainloaded display/dcp experiments to start with the state left by iboot. Signed-off-by: Janne Grunau <j@jannau.net>
Apperently just informative as display init on M2 Ultra in m1n1 worked as expected despite passing '0' as die number. Signed-off-by: Janne Grunau <j@jannau.net>
dcpext0 behaves like dcp on M1* devices and can sleep after display init. This has the advantage of not breaking macOS when starting with an initialized display. dcpext* are according to Apple's tech specs slightly more powerful than dcp. They are advertised as 6K at 60Hz while dcp seems to be limited to 5K at 60Hz. Signed-off-by: Janne Grunau <j@jannau.net>
Only observed with dcp/dptx in linux after initialisation and reset in m1n1. On the initial startup dcp sends two D576 (hotPlug_notify_gated) presumendly due to state confusion due to the multiple dptx connections. Signed-off-by: Janne Grunau <j@jannau.net>
Also fixes a type for set_idle_caching_state_ap. Signed-off-by: Janne Grunau <j@jannau.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches j473, j474s and j475c to dcpext(0) as display co-processor for HDMI out. Main reason is that dcpext(0) wakes up after sleep + reset. This simplifies handling in m1n1 a little.
This contains the tracing/m1n1.dcp changes for the rarely used OOB ASYNC callback channel.
In addition holds some minor fixes. The die number fix should be cosmetically, dcp firmware doesn't seem use it for something essential in a dptx connection.