Shell: do not access properties on startup #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the way the shell finds methods to add to the locals on startup: the methods are queried on the object’s class, rather than the object itself. This allows detecting if an object’s member is a property and ignore it, rather than accessing the property. Attributes whose name starts by ‘_’ are also now ignored, which avoids importing private methods or Python magic methods in the shell namespace. Fixes spurious accesses to ProxyUtils’s SIMD properties (b, h, etc) on shell startup, which caused a ProxyCommandError if m1n1 is not recent enough. Signed-off-by: Vincent Duvert <vincent@duvert.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_(private methods and Python magic methods).This removes the following items from the shell namespace (as checked by
dir()):If I’m not mistaken, they are not actually useful.