Replies: 1 comment
-
Does VS have an Auto Formatter like Eclipse? At Work everyone who pushes a new change must have atleast the autoformatter and save actions which will always called at save so the code pushed belongs to our codestyle... |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
So there is a lot of things we could discuss here, but the most important topic in the last few years was:
codestyle VS functionality
Sure we have a codestyle and yes we should use it always, but what to do with a large PR knowing it brings a lot of functionality but does not really fit our codestyle?
Sometimes I review it and add my comments about style to it, sometimes I merge it anyway and fix the style myselfe, but why?
I know that people spend a lot of time to PRs and the moment I feel they get bored and tired of constant changerequests, I merge it and change the style later.
What do you think about it? Should we never ever merge PRs with the wrong style?
Beta Was this translation helpful? Give feedback.
All reactions