Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor + Testing #2

Merged
merged 23 commits into from Sep 10, 2023
Merged

Refactor + Testing #2

merged 23 commits into from Sep 10, 2023

Conversation

wilgaboury
Copy link
Contributor

@wilgaboury wilgaboury commented Sep 10, 2023 •
edited

Most notable changes:

  • make redis pool struct generic to work with both single instance and clustered connections
  • remove lock from pool queue
  • add optional upper bound on amount of connections
  • add basic automated integration tests

@wilgaboury
Generify code, don't use locks, await empty pool
f3b225f
@wilgaboury
Move cluster to separate module, remove inner pool
876a93f
@wilgaboury
Add simple integration test
9d3dd3e
@wilgaboury
Fix errors in cluster code
1c0255f
@wilgaboury
Add convenient type aliases
2577cd6
@wilgaboury
Use loop to exhaust queue
c66fd83
@wilgaboury
Clean up deps, assert send + sync
b905e69
@wilgaboury
Rename create methods to new
a5a02e2
@wilgaboury
Move cluster con factory to cluster module
5f8add6
@wilgaboury
Fix readme example and provide manual clone
546e797
@wilgaboury
Fix readme
74b6342
@wilgaboury
Minor cleanup
f9e950e
@wilgaboury
Make separate pool size and connection limit
75dfef7
@wilgaboury
Create another redis integration test, scaffold out cluster test utils
89045b2
@wilgaboury
Create unit tests for cluster pool
1e19754
@wilgaboury
Dockerize redis cluster for tests
1325527
@wilgaboury
Create scripts folder, cleanup test
330976b
@wilgaboury
Move single to it's own module
d37ed18
@wilgaboury
Update readme
d19407f
@wilgaboury
Minor refactor, test bad connection eviction, create custom single re…
e160730 
…dis image
@wilgaboury
Make connection limit optional
c208cc9
@wilgaboury
Update readme
610a787
genusistimelord
genusistimelord approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

the refactoring went well and the tests are a great addition. thank you for all your hard work.

@genusistimelord genusistimelord merged commit b19f37a into AscendingCreations:main Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genusistimelord genusistimelord genusistimelord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wilgaboury @genusistimelord