Fixes map updates when metrics is false. (#855) #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arufonsu
force-pushed
the
MetricsFreezeFix
branch
from
08f5116
to
2e8b93d
Compare
* Should resolve AscensionGameDev#855
Arufonsu
force-pushed
the
MetricsFreezeFix
branch
from
2e8b93d
to
eb9979b
Compare
jcsnider
approved these changes
Dec 13, 2021
lodicolo
added a commit
that referenced
this pull request
Apr 4, 2022
* Fixes map updates when metrics is false. (#1005) * Should resolve #855 * Fix 1174 (#1175) * fix: Daywalkr - Fix for guild bank OOBs * fix: Daywalkr - Add migration to prevent possible guilds having too many bank slots after change; fix event command for adding guild bank slots * chore: Daywalkr - 1174 code review * chore: Review; cleanup weird contextmodelsnahpshot change Co-authored-by: Arufonsu <17498701+Arufonsu@users.noreply.github.com> Co-authored-by: AVild <ajv2324@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapUpdateQueue was updating the map within the ActiveMaps check, while inside the enabled check for metrics only.
By moving this check for active maps along with MapUpdateQueue, out of this previously mentioned check for enabled metrics, we can now still enjoy metrics doing it's job properly (to work or not) whenever it's enabled or disabled, without interrupting the gameplay map updates.
Should resolve #855