fix: LoadAnimationTexture, Sprite and TransformedSprite #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arufonsu
added
the
chore
lodicolo
requested changes
May 9, 2023
Arufonsu
force-pushed
the
fix/1806
branch
2 times, most recently
from
47dfbb6
to
957505d
Compare
- Previous attempt to fix AscensionGameDev#1649 by swapping `Sprite ?? TransformedSprite` for `TransformedSprite ?? Sprite` at SpellCast specifically was a total mess as it broke Weylon's custom animation override for casting. So, after some testing and code reading, i've concluded that replacing these with `string.IsNullOrEmpty(TransformedSprite) ? Sprite : TransformedSprite` is instead, the good way to go, this fixes the originally reported issues at AscensionGameDev#1649 while maintaining the original behavior for non-transformed entities. - review: uses IsNullOrWhiteSpace
|
updated with |
lodicolo
approved these changes
Jun 5, 2023
naziozeno
pushed a commit
to naziozeno/Intersect-Engine
that referenced
this pull request
Jul 18, 2023
…eDev#1807) - Previous attempt to fix AscensionGameDev#1649 by swapping `Sprite ?? TransformedSprite` for `TransformedSprite ?? Sprite` at SpellCast specifically was a total mess as it broke Weylon's custom animation override for casting. So, after some testing and code reading, i've concluded that replacing these with `string.IsNullOrEmpty(TransformedSprite) ? Sprite : TransformedSprite` is instead, the good way to go, this fixes the originally reported issues at AscensionGameDev#1649 while maintaining the original behavior for non-transformed entities. - review: uses IsNullOrWhiteSpace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sprite ?? TransformedSpriteforTransformedSprite ?? Spriteat SpellCast specifically was a total mess as it broke Weylon's custom animation override for casting. So, after some testing and code reading, i've concluded that replacing these withstring.IsNullOrEmpty(TransformedSprite) ? Sprite : TransformedSpriteis instead, the good way to go, this fixes the originally reported issues at bug: Transform Effect changes Sprite while Casting #1649 while maintaining the original behavior for non-transformed entities.