Fix party max vitals being set to 0 resulting in a divide by 0 issue. #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen health or mana is set to 0.
Cheshire92
changed the title
Why even bother with the else? Assume it's full by default. I copied the code from the EntityBox a litttle too eagerly.
jcsnider
approved these changes
May 8, 2020
|
Thanks Joyce. Looks good. |
lodicolo
approved these changes
May 8, 2020
jcsnider
added a commit
that referenced
this pull request
May 9, 2020
…#201) (#203) * Fix a divide by zero issue causing party vitals to crash the client when health or mana is set to 0. * Minor clean-up. Why even bother with the else? Assume it's full by default. I copied the code from the EntityBox a litttle too eagerly. Co-authored-by: Joyce <azurebeats@hotmail.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #199
This fix checks to see if the player's max vital for health or mana is over 0 before doing any math to see how to resize the bar, much like it works on the EntityBox. If max vital is not over 0, just set the bar to display as full like it does on the EntityBox.