Add Chatbox tabs and the ability to tag messages with categories. #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed a couple of small things and changed the UI for it a little to look less.. slapped together. |
Cheshire92
changed the title
Closed
Closed
…and System tabs. Fix a potential localization crash should none exist.
|
Looks good to me. @lodicolo when we merge this in, someone tag me or PM me in discord so I can add the extra resources into the assets repo. |
jcsnider
previously approved these changes
Sep 27, 2020
jcsnider
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #329 partially, future PR possibilities to make the chatbox tabs user configurable rather than hardcoded and expose an option to mark event chat additions with specific tags.
Went through every single chat message I could find and marked them accordingly.
Documented some chatbox related stuff I came across.
Made it so the generic tabs (All and System) remember the last chat channel you set for them, the others will change the channel to the relevant channel by default.
Adding new tabs is relatively easy, just need to configure what they should display, default the channel to and say in the source code, and add the localization stuff for them.
Client resources: https://www.ascensiongamedev.com/resources/filehost/398ddf1e96ace2414aad42ce02cd444e.zip (Updated)