Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended API Endpoints #602

Merged
merged 12 commits into from Apr 18, 2021
Merged

Extended API Endpoints #602

merged 12 commits into from Apr 18, 2021

Conversation

jcsnider
Copy link
Contributor

Users List

  • Added search parameter that searches against name and email address
  • Added sort parameter which will sort via email or name

Players List

  • Added search parameter that searches against name and email address
  • Added sort parameter which will sort via name or rank (level + experience)

User Name Changes

Player Name Changes

Deleting Users

Deleting Players

Bug Fixes

Cannot use compiled queries entirely for this yet. Maybe if we upgrade to EF Core 5... sorting would have to be done by referencing properties (like User.Name) with EF.Property<string>(User, "Name") BUT then the order is off due to not handling case sensitivity correctly which can potentially be resolved by specifying collations which isn't supported until EF Core 5.
…layers list so you don't get inventory and other heavy data.
EF hashes and caches queries automatically anyways.
@jcsnider jcsnider added this to In progress in Beta 7 via automation Mar 20, 2021
@jcsnider jcsnider added this to the 0.7-beta milestone Mar 20, 2021
@jcsnider jcsnider marked this pull request as ready for review April 16, 2021 11:35
@jcsnider jcsnider requested a review from lodicolo April 16, 2021 11:38
Beta 7 automation moved this from In progress to Reviewer approved Apr 17, 2021
@jcsnider jcsnider merged commit bed3df3 into prerelease Apr 18, 2021
Beta 7 automation moved this from Reviewer approved to Done Apr 18, 2021
@jcsnider jcsnider deleted the extended-api-endpoints branch April 18, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants