We don't need to be handling input for all the players we are updatin… #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g only our player.
Irokaiser
approved these changes
Apr 2, 2020
lodicolo
added a commit
that referenced
this pull request
Apr 3, 2020
* Fixing bugs (#47) * Should fix 198, server crash due to projectile trying to hit an event * Harden accept trade packet to return if counterparty is null. * Fixing potential NREs * Fixes another potential NRE and out of bounds error * Don't want to handle packets for null clients, but also don't want to be throwing exceptions * Fixes a small error where empty passwords crash the server during migration * Updated licensing leading up to open source release (#49) * Create FUNDING.yml (#50) * Use dynamicsoundeffects for music instead of mediaplayer (#51) * Fixing bugs (#52) * Should fix 198, server crash due to projectile trying to hit an event * Harden accept trade packet to return if counterparty is null. * Fixing potential NREs * Fixes another potential NRE and out of bounds error * Don't want to handle packets for null clients, but also don't want to be throwing exceptions * Fixes a small error where empty passwords crash the server during migration * Small edit so that networking doesn't alter ui, only triggers ui to update next draw * Fixed events jumping all over the place * Allow checking of evtMap parameter even if no page instance has spawned * Basic bounds checking on pathfinding to potentially fix Weylon's bug. * Fix for events being able to step on traps. * Stop caching of expressions as they are used once * Fixed select character window not resetting paperdolls properly when cycling through characters * Fixes empty friends list when opening friends via a hotkey * Added server loop lock for when updating game objects (less likely to have deadlocks if not processing npcs when updating npcs, for example) * Fix collection changed bug when maps update while server loop is running * Fixes weird instance where the server would error while trying to send a map to a client who didn't have an entity set * Adds SpellCd back into the PlayerContextModelSnapshot since it was never actually removed from the database. (#56) * Fixing db context model snapshot formatting (#58) * Adds SpellCd back into the PlayerContextModelSnapshot since it was never actually removed from the database. * EF expected formatting fix for game context model snapshot * We don't need to be handling input for all the players we are updating only our player. (#62) * Properly load list data within locking region (#70) * Cleanup code in RefreshToken * Actually load list data before exiting locking region * Fix event graphic selector not opening to current graphic (#72) Co-authored-by: Robert Lodico <lodico.rj@gmail.com>
RedBandana
pushed a commit
to RedBandana/Intersect-Engine
that referenced
this pull request
Apr 5, 2020
…eDev#73) * Fixing bugs (AscensionGameDev#47) * Should fix 198, server crash due to projectile trying to hit an event * Harden accept trade packet to return if counterparty is null. * Fixing potential NREs * Fixes another potential NRE and out of bounds error * Don't want to handle packets for null clients, but also don't want to be throwing exceptions * Fixes a small error where empty passwords crash the server during migration * Updated licensing leading up to open source release (AscensionGameDev#49) * Create FUNDING.yml (AscensionGameDev#50) * Use dynamicsoundeffects for music instead of mediaplayer (AscensionGameDev#51) * Fixing bugs (AscensionGameDev#52) * Should fix 198, server crash due to projectile trying to hit an event * Harden accept trade packet to return if counterparty is null. * Fixing potential NREs * Fixes another potential NRE and out of bounds error * Don't want to handle packets for null clients, but also don't want to be throwing exceptions * Fixes a small error where empty passwords crash the server during migration * Small edit so that networking doesn't alter ui, only triggers ui to update next draw * Fixed events jumping all over the place * Allow checking of evtMap parameter even if no page instance has spawned * Basic bounds checking on pathfinding to potentially fix Weylon's bug. * Fix for events being able to step on traps. * Stop caching of expressions as they are used once * Fixed select character window not resetting paperdolls properly when cycling through characters * Fixes empty friends list when opening friends via a hotkey * Added server loop lock for when updating game objects (less likely to have deadlocks if not processing npcs when updating npcs, for example) * Fix collection changed bug when maps update while server loop is running * Fixes weird instance where the server would error while trying to send a map to a client who didn't have an entity set * Adds SpellCd back into the PlayerContextModelSnapshot since it was never actually removed from the database. (AscensionGameDev#56) * Fixing db context model snapshot formatting (AscensionGameDev#58) * Adds SpellCd back into the PlayerContextModelSnapshot since it was never actually removed from the database. * EF expected formatting fix for game context model snapshot * We don't need to be handling input for all the players we are updating only our player. (AscensionGameDev#62) * Properly load list data within locking region (AscensionGameDev#70) * Cleanup code in RefreshToken * Actually load list data before exiting locking region * Fix event graphic selector not opening to current graphic (AscensionGameDev#72) Co-authored-by: Robert Lodico <lodico.rj@gmail.com> Signed-off-by: Bandana <aurelende@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client was handling player input every time it updated any player. Instead we should only do it when updating self.