-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ITV Downloads still fail after update to version 1.21.10 #339
Comments
Can confirm this issue - I received exactly the same results when testing. |
Same for me, from the UK, so no VPN issue. I tried the Jonathan Ross Show. Failed immediately. |
The Python crypto support was changed in 1.2.10, and appears to be broken. If you see this before upgrading, don't upgrade and wait for a fix. If you have already upgraded, you can roll back to 1.21.9 and replace the bundled version of youtube-dl as describe in #331 (comment) . But the best course of action is probably to wait. This shouldn't affect BBC programmes. |
thanks @sleaux-meaux ! I had already upgraded, but your fix worked perfectly! |
It appears that the Python 3 version of PyCryptodome was included in GiA, but that isn't digestible to Python 2. EDIT: I think a Python 2 version of PyCryptodome can be used with both Python 2 and 3. |
Ignore my earlier suggestion to temporarily replace /Applications/Get iPlayer Automator.app/Contents/Resources/Crypto with the equivalent folder from 1.21.9. That is not a good idea if you are using Python 3 with GiA since the old PyCrypto package won't load and ITV downloads will be delegated to ffmpeg. |
OK, already did that and downloaded some things. Are they compromised? I do have Python 3 on my system but how do I know if GiA is using it (as opposed to v2). Should I remove GiA and follow your first recommendation (install v.1.21.9 and replace YouTube.dl)? |
Downloads won't be compromised. They either decrypt or they don't. GiA 1.2.10 tries these locations for Python, in this order. Check versions with: /usr/local/bin/python --version GiA 1.2.9 and earlier don't check /usr/local/bin. With verbose logging, youtube-dl will also print a line that looks this: [debug] Python version 3.9.4 (CPython) - macOS-10.15.7-x86_64-i386-64bit If you replaced Crypto folder and it's working, it means Python 2 is being used, so no need to change. If something goes wrong, you can always reinstall GiA and start over. |
thanks for interest,
|
youtube-dl only looks for "python", so "python3" would be ignored. For completeness, you should check full paths (/usr/local/bin/python3 and /usr/bin/python3) so you know what is where. |
cheers. |
I am also having problems with ITV downloads, I was able to download 2 episodes of series 1 of Bancroft but the other 2 would not download and the same with episode 1 of series 2. Failed download solutions shows problem unknown, logs detail in attached file |
PyCryptodome is supposed to support Python 2.6, 2.7 and 3.4 and up, which is why I didn't expect a problem. I copied over what pip installed into my Python3 installation. For those of you still having problems, can you post a verbose log? I need to see how youtube-dl is failing for you. |
I can back out the crypto and path changes, but I'd like to understand a bit more why it's okay on my system and not others. |
Error shown below, running under Python 2. There are separate PyCryptodome wheels installed for Python 2 and 3. The Python 3 wheel is built against Python 3 stable ABI, thus not compatible with Python 2, but the Python 2 wheel works with Python 3. Install PyCryptodome in Python 2 and copy its Crypto folder.
|
Correction: Don't just roll back to PyCrypto - it doesn't seem to work with Python 3. Forgot my own advice above. Would be OK if you return to forcing use of /usr/bin/python, though. |
No go for me using Catalina. I was so pleased to see the prompt for the 21 update but alas it doesn't work. C'est la vie |
Can I get a volunteer to try this test build? I think I have figured out how to include python in the app so GiA isn't dependent on a system-installed python. If you can download ITV content (or you can't) with this build let me know. I'd especially like folks running earlier versions of macOS to try it, as I'm not sure the included python runs on older versions of macOS. |
trying it now.
… On May 6, 2021, at 4:49 PM, Scott Kovatch ***@***.***> wrote:
Can I get a volunteer to try this test build? I think I have figured out how to include python in the app so GiA isn't dependent on a system-installed python.
Link to GDrive <https://drive.google.com/file/d/1XZfsNbP1y5t77w7u0NeUmuI7H02ux7pD/view?usp=sharing>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#339 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEDRDZQBPJPR6AZ3XX6BPSLTML6D5ANCNFSM44GMORZQ>.
|
It failed for an ITV show..
Downloading In for a Penny: Series 3
INFO: Preparing Request for Auth Info
INFO: Requesting Metadata.
DEBUG: Metadata response status code: 200
INFO: Metadata processed.
DEBUG: youtube-dl args:["/private/var/folders/7j/5bqkw1wn3kl_y3g7ym7zr9400000gn/T/AppTranslocation/C42905CC-BA09-41CC-9969-D8401C024110/d/Get iPlayer Automator.app/Contents/Resources/youtube-dl", "https://www.itv.com/hub/in-for-a-penny/2a5241a0019", "-f", "mp4/best", "-o", "/Users/ian02054/Movies/radio/In for a Penny/In for a Penny.s03e03.Episode 3.%(ext)s", "--verbose"]
DEBUG: youtube-dl environment: ["PATH": "/private/var/folders/7j/5bqkw1wn3kl_y3g7ym7zr9400000gn/T/AppTranslocation/C42905CC-BA09-41CC-9969-D8401C024110/d/Get iPlayer Automator.app/Contents/Resources:/private/var/folders/7j/5bqkw1wn3kl_y3g7ym7zr9400000gn/T/AppTranslocation/C42905CC-BA09-41CC-9969-D8401C024110/d/Get iPlayer Automator.app/Contents/Resources/get_iplayer/utils/bin:/private/var/folders/7j/5bqkw1wn3kl_y3g7ym7zr9400000gn/T/AppTranslocation/C42905CC-BA09-41CC-9969-D8401C024110/d/Get iPlayer Automator.app/Contents/Resources/venv/bin"]
youtube-dl finished downloading
AppController: Downloads Finished
Was using the patched Sleaux-meaux version before, and that show downloaded ok with that. (I cleared the show from history before trying)
just failed with problem unknown
… On May 6, 2021, at 4:49 PM, Scott Kovatch ***@***.***> wrote:
Can I get a volunteer to try this test build? I think I have figured out how to include python in the app so GiA isn't dependent on a system-installed python.
Link to GDrive <https://drive.google.com/file/d/1XZfsNbP1y5t77w7u0NeUmuI7H02ux7pD/view?usp=sharing>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#339 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEDRDZQBPJPR6AZ3XX6BPSLTML6D5ANCNFSM44GMORZQ>.
|
All I really want mostly is ITV news for my youtube channel. As I said I can't even watch via the kodi 'itv player' add on anymore :( |
What version of macOS are you using? |
URL: https://www.itv.com/hub/superstore/2a5460a0107 Runs on Catalina, but there is no crypto support bundled, so delegates to ffmpeg. Fails on Yosemite, with no clues in the log. I don't think you can just ship a virtualenv created with Homebrew Python. The included python binary references the Python framework in its Homebrew location, which won't exist for most people. I expect it only ran for me on Catalina because I have Homebrew Python installed. |
Bah. I thought "python venv --copies" copies in everything you need for a python distribution, but I guess not. |
High sierra 10.13.6
Tried others shows and got same issue..i knew that one had worked 5 mins
before you sent the test...so wanted to try that.
…On Thu, May 6, 2021, 17:19 Scott Kovatch ***@***.***> wrote:
just failed with problem unknown
What version of macOS are you using?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#339 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEDRDZVWVGX34NU5NBQ2U5TTMMBVXANCNFSM44GMORZQ>
.
|
OK, I give up for now. I've reverted out the crypto and path changes and pushed a new version. |
It doesn't run on Catalina with me |
Can confirm the rolled-back version is working perfectly on Big Sur now |
That might actually work... I have the youtube-dl sources so I built it and then pyinstaller. I was able to get a runnable youtube-dl distribution. I don't have your patch, so I'd have to get that and rebuild it. I'll work with it some more after work today. |
@skovatch wrote:
FTR, this is only true up to
MacOS X 10.6 supported on Python 2.7.x/3.5.x/3.6.x/3.7.x; Current
i.e. MacOS X 10.6 support is dropped; the abi3 variety should be install-able on Python >= 3.5.0 The PyCryptodome module comprises C extensions (.so files - .pyd on Windows) that need to have been compiled by the same (or compatible) version of the C compiler used to compile the respective Python binaries - thus, interchange-abitlity between the The dead (but not buried 😉 ) PyCrypto module is only officially available as source, i.e. no wheels; it was tested against Python 2.1 through to 3.3; it, too, includes C extensions; in theory, it is possible to compile it from source (and install) on a Python 3 enabled Mac, but you should use the same compiler (OS X SDK?) your Python 3 version was built with... |
I saw this error again this morning. I had 1 successful ITV download and one failed (consistently). Same show. Log below...
|
You cannot download episodes that are not available to mobile devices, as is the case here. If you have a suitable phone, check the episode there first. If it isn't available on your phone, it's a good bet it won't be available to download. |
OK, but does that make sense given I downloaded the episodes before and after (just checking)? |
I've come to this party a little late, but my ITV downloads have also stopped working, but I haven't updated GIA, still running 1.21.2 on El Capitan. It was working fine for ITV last I checked, but I don't download from them that often. Has this issue somehow affected older un-updated versions too? |
hi @pmhird I just downloaded Endeavour s08e02 just fine. I am running GiA 1.21.12 on Big Sur. |
I've now updated to 1.21.12 on El Capitan. BBC still working absolutely fine, but I can't get anything to succeed from ITV. With the latest update to 1.21.12 do I still need ot re-do the little Python 2.7 trick outlined in issue 277? |
Can anyone help with this? It seems to be failing at the "Downloading m3u8 information" stage, suggesting it can't find a corresponding mobile format episode, but I checked and I can watch the episode (Hollington Drive S01E01) on both web browser and itvhub app. What is going on? It seems to affect all ITV shows for me, can't get anything to download at all. BBC both TV and radio are fine, but seem to take a lot longer to download after 1.21.12? I'm using El Capitan. Thanks in advance, here's the relevant bit of the log where the ITV downloads fail: [ITV] 10a0552a0001: Downloading m3u8 information |
I don’t use El Capitan, but just to confirm, are you using a VPN? |
Yes I am on a VPN, but the same VPN works fine for BBC and also for viewing ITV in a web browser or mobile app... |
Hi,
downloads from itv still stop almost instantly after starting and fail.
INFO: Loading proxy settings...
INFO: No proxy to load
INFO: Proxy load complete.
INFO: No proxy will be used
AppController: Starting Downloads
Downloading Show 1/1:
Downloading Superstore: Series 6
INFO: Preparing Request for Auth Info
INFO: Metadata processed.
youtube-dl finished downloading
AppController: Downloads Finished
The text was updated successfully, but these errors were encountered: