Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query iPlayer Downloads ((hlsfhd)) #395

Closed
timstaton1 opened this issue Mar 27, 2022 · 5 comments
Closed

Query iPlayer Downloads ((hlsfhd)) #395

timstaton1 opened this issue Mar 27, 2022 · 5 comments

Comments

@timstaton1
Copy link

This is the first time I've reported an issue on here so bare with me...

I quite like the fact that Get iPlayer now supports 1080p resolution, so thank you for that.
I am currently updating all my old series to 1080p (the ones I can anyway) and have noticed that some files will download with the expected 1080p file e.g. ((dashfhd)) but some, even within the same series download as ((hlsfhd)) which comes out as just the audio file but no video file even though the file size is similar to the ((dashfhd)) files that are around the same series.

What steps will reproduce the problem? Be specific, and provide as much detail as possible.
I've tried several times with the same thing. Preferences all set to download the highest quality for the Program and when downloading the episode it downloads it without the video.

What is the expected output? What do you see instead?
I get a file with the appendix 'xxx' ((hlsfhd).mp4 which produces a large file but only the audio
I was expected 'xxx' ((dashfhd)).mp4 which is what happens even within the same series of the program

What version of GiA are you using? On what version of OS X?
Version 1.22.1 (20220216001) on MacOS 12.3 on an M1 Mac Mini
(but the same happens with an Intel-based Mac)

Are you using a web proxy? DNS proxy? VPN? VPS?
No - I've never been able to use ExpressVPN with Get iPlayer (maybe this is something that someone could help me with too, please)??

*What program are you attempting to download (full title, series and episode)? Provide only ONE program as an example. *
Death in Paradise Series 5 - 01. Episode 1 ((hlsfhd))

Please provide any additional information below.

@skovatch
Copy link

This is a quirk of get_iplayer. The author of get_iplayer found that the 1080p videos downloaded faster using DASH, which downloads a separate audio and video stream and then stitches them together using ffmpeg. For all other quality it uses hls streams, which are combined audio and video. It's possible that some shows don't have 1080p streams, which would explain why some of your downloads fall back to the 720p version.

It's also possible that I'm misunderstanding you and you're not getting both audio and video for some programs?

@timstaton1
Copy link
Author

timstaton1 commented Mar 27, 2022 via email

@sleaux-meaux
Copy link

Those old programs aren't technically supported by get_iplayer, but it obviously has a bug in handling cases where 1080p video is not found. If you're planning to download a lot of these, switch to get_iplayer itself and use --tv-quality=fhd --exclude-format=hls to work around the problem. That should ensure that nothing is downloaded unless 1080p is available.

@skovatch
Copy link

As you suspected this is a bug in get_iplayer, and was fixed in 3.30. I'll have to merge it in.

@skovatch
Copy link

Fixed with v1.24.0, which had the newer version of get_iplayer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants