Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBR support again? (Since it's implemented in Iris) #182

Open
shanoaice opened this issue Sep 11, 2022 · 0 comments
Open

PBR support again? (Since it's implemented in Iris) #182

shanoaice opened this issue Sep 11, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@shanoaice
Copy link

shanoaice commented Sep 11, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Sometimes when resource packs change things quite a bit, integrated PBR of some shaders (which works normally without explicit support, at least the ones in Complementary Shaders works well) won't perform very well, and resource-pack bundled PBR can help provide a correct rendering.

Describe the solution you'd like
Iris has already implemented the PBR support (Issue: IrisShaders/Iris#130, PR: IrisShaders/Iris#1401), there shouldn't be a big issue to port that to Forge (I assume, correct me if I'm wrong).
@shanoaice shanoaice added the enhancement New feature or request label Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shanoaice