Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the data and mime type attributes to the TicketAttachment #23

Merged
merged 5 commits into from
Sep 29, 2018
Merged

Added the data and mime type attributes to the TicketAttachment #23

merged 5 commits into from
Sep 29, 2018

Conversation

MarvinKlar
Copy link
Contributor

No description provided.

@MarvinKlar MarvinKlar mentioned this pull request Sep 26, 2018
Closed
mundza
mundza approved these changes Sep 26, 2018
View reviewed changes
Copy link

@mundza mundza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usefull - exactly what was missing

@MarvinKlar
Copy link
Contributor Author

Made some attributes of the Ticket and TicketArticle nullable to not require them at creation to fix #25

mundza
mundza approved these changes Sep 27, 2018
View reviewed changes
Copy link

@mundza mundza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useful

@Asesjix Asesjix changed the base branch from master to develop September 29, 2018 13:13
@Asesjix Asesjix merged commit 86ed90d into Asesjix:develop Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mundza mundza mundza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarvinKlar @mundza @Asesjix