i18n for slugs. Used config file to avoid performance impact #29
Conversation
| $locale = LaravelLocalization::setLocale() ?: App::getLocale(); | ||
| $router->get('posts', ['as' => $locale . '.blog', 'uses' => 'PublicController@index']); | ||
| $router->get('posts/{slug}', ['as' => $locale . '.blog.slug', 'uses' => 'PublicController@show']); | ||
| $router->get(trans('blog::settings.posts-slug'), ['as' => $locale . '.blog', 'uses' => 'PublicController@index']); |
There was a problem hiding this comment.
While we're at it, can we get rid of the $locale in the route names? It doesn't appear to do anything at all.
There was a problem hiding this comment.
I am not sure, but I think it would not be the same for the route name en.blog as it would be for fr.blog.
A language switcher may need this information to switch between languages without losing the current scope.
|
Could this be a config item instead, similar to the backend URL? |
|
Did you test that changing from one locale to another redirects to the correct URI ? |
|
I did. Although I think there may be problems with non-existent languages configs since there is no fallback to a custom string if the translation does not exist. Something like:
|
|
I'm closing this since I think every module in the future would need localised slugs. And that should be in a separate slugs.php file, not settings.php. Cleaner and clearer. |
No description provided.