Updated Post Scopes To Use The Status Object #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ard coded integers
|
Very nice! Thank you! 👍 |
|
Hm this broke the build of php 5.6 https://travis-ci.org/AsgardCms/Blog/jobs/238512805 |
|
@nWidart I dont think this PR broke the build, I believe the test is flawed. If I run the test a number of times if fails about 10% of the time (even before this was merged). That would also explain why Travis didn't complain when this PR was opened but then did when it was merged. I think it is something to do with the additional calls to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the hard coded status integers in the Post scopes with references to the Status object constants