Allow another database then mysql while running the installation script #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitpick-CI
reviewed
May 13, 2017
| @@ -122,16 +140,20 @@ protected function askDatabasePassword() | |||
| } | |||
|
|
|||
| /** | |||
| * @param $driver | |||
|
Hello, Thank you for the contribution! |
removed whitespace
|
will do :) |
nWidart
pushed a commit
to AsgardCms/Platform
that referenced
this pull request
May 15, 2017
* Allow other database drivers With this changes, it's possible to define another database driver. It's now also possible to change the port. Moved from AsgardCms/Core#103 * Update ConfigureDatabase.php removed spaces * Update EnvFileWriter.php
nWidart
pushed a commit
to Idavoll/Core
that referenced
this pull request
May 15, 2017
* Allow other database drivers With this changes, it's possible to define another database driver. It's now also possible to change the port. Moved from AsgardCms/Core#103 * Update ConfigureDatabase.php removed spaces * Update EnvFileWriter.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this changes, it's possible to define another database driver.
It's now also possible to change the port.
I updated also the composer.json to keep in sync with: https://github.com/Idavoll/Core/blob/2.0/composer.json