Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing menu types #31

Merged
merged 24 commits into from Aug 27, 2016
Merged

Introducing menu types #31

merged 24 commits into from Aug 27, 2016

Conversation

nWidart
Copy link
Member

@nWidart nWidart commented Aug 1, 2016

This is the PR #24 integrated into 2.0 as well as some minor fixes to it.

use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Migrations\Migration;

class AddLinkTypeColymnToMenuitemsTable extends Migration {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Each class must be in a namespace of at least one level (a top-level vendor name)
  • Opening brace of a class must be on the line after the definition

@nWidart
Copy link
Member Author

nWidart commented Aug 1, 2016

Pending issues:

  • if an item had a parent, which generated a URI like page1/menu_item, setting it as root, doesn't update URI
  • Moving an item that was a root item, back as a child to another page, removes the correct uri
    • makes it menu_item
    • should be page1/menu_item
  • Changing the page of a menu item: fails
  • Creating a new menu item, and selecting a parent_id does nothing
  • Drag & dropping menu items from the menu edit view, doesn't generate the full URI (page1/menu_item)

Big issue: the menu item is fetched, before even saving, which always results in bad state. A second save is often needed to actually perform the correct operation, since it fetches old data from the database.

@nWidart
Copy link
Member Author

nWidart commented Aug 2, 2016

  • Update uris on page slug change (all translations)
  • Double check all possible combinations of parent/child
  • Update drag&drop to use new uri things
  • Don't load items in parent dropdown that are already parent of current menuItem

@nWidart nWidart merged commit 84933c8 into 2.0 Aug 27, 2016
@nWidart nWidart deleted the feature/menu-types branch August 27, 2016 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants