Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parametrized the owner and group for ash_cli #108

Merged
merged 1 commit into from
Dec 14, 2023
Merged

parametrized the owner and group for ash_cli #108

merged 1 commit into from
Dec 14, 2023
+14 −10

Conversation

ngurmen
Copy link
Contributor

@ngurmen ngurmen commented Dec 13, 2023

Linked issues

None

Dependencies

None

Changes

  • added owner and group parameters to defaults
  • updated role to use the new owner and group parameters
  • default values for both are root as before

Breaking changes

None

Additional comments

None

leopaul36
leopaul36 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@leopaul36 leopaul36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @ngurmen 🙏

@leopaul36 leopaul36 merged commit ea49701 into AshAvalanche:main Dec 14, 2023
@leopaul36
Copy link
Contributor

Released v0.9.2 and updated the docs

@ngurmen ngurmen deleted the mng/owner_group_parameters_for_ash_cli branch December 14, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuttymoon Nuttymoon Nuttymoon approved these changes

@leopaul36 leopaul36 leopaul36 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ngurmen @leopaul36 @Nuttymoon