-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add faucet role #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuttymoon
reviewed
Mar 22, 2023
Nuttymoon
reviewed
Mar 22, 2023
Looks good to me. We will just have to document that this is not compatible with enabling HTTPS on API endpoints. Or maybe we can mount the OS root certificates to the container and then it might work. |
Co-authored-by: Gauthier Leonard <gauthier@e36knots.com>
leopaul36
force-pushed
the
36-faucet-role
branch
from
March 23, 2023 18:09
1d9858c
to
f322897
Compare
This was referenced Mar 23, 2023
|
Nuttymoon
requested changes
Mar 26, 2023
Nuttymoon
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use the same config name as in the faucet config.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
Changes
ash.avalanche.faucet
role andinstall_faucet_docker
playbookAdditional comments
A few remarks:
ghcr.io/ashavalanche/faucet-image:disable-captcha-variable
built from ourdisable-captcha-variable
branch.config.json
is included in the image which is not really flexible. For now we override it with a volume in the docker-compose file to make a configurable container instance.erc20tokens
configuration allows to load additional ERC-20 tokens in the faucet. Referring to a something that is not an actual deployed ERC-20 smart contract makes the app fail so let's not support this for the first iteration.evmchains
supports multiple chains. We only template a single chain in the config file for now to keep things simple at first.How to test
faucet
group withvalidator01
avalanche_faucet_config['subnet_rpc']
with a valid RPCansible-playbook ash.avalanche.install_faucet_docker -i inventories/local
I will write the README and tutorial for Ash docs once you validate the technical part.