-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ash_cli module #63
Conversation
Docs PR: AshAvalanche/ash-docs#42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few remarks:
- A role named
ash_cli
already exists. What aboutash_cmd
orash_command
for the module name? (can be both with a symlink) - I would appreciate having the command run as a string in the output. E.g.
command: /usr/local/bin/ash avalanche node info
- We should handle positional arguments: maybe with a
positionals
module argumentpositionals=dict(type="list", required=False, default=[]),
Note that the module actually already supports positionals if we pass them in the |
Co-authored-by: Gauthier Leonard <gauthier@e36knots.com>
|
3a8cbd7
to
8ba007b
Compare
Co-authored-by: Gauthier Leonard <gauthier@e36knots.com>
Linked issues
Changes
ash.avalanche.ash_cli
Ansible moduleAdditional comments
There is still room for improvements:
ok
orfatal
. We could returnchanged
once we merge the transaction feature to Ash CLI.