Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add-validator vars propagation #82

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Fix add-validator vars propagation #82

merged 2 commits into from
Jul 6, 2023

Conversation

Nuttymoon
Copy link
Contributor

Linked issues

Changes

  • avalanche.node
    • Rename validator vars in the node role to avoid overlapping with var names in the subnet role
    • Explicitly pass vars in the include_role task
  • avalanche.ash_cmd
    • Directly call the Ash CLI binary instead of the script in /bin/local. This is to avoid conflicts in env vars
    • Add the ash_config argument

@Nuttymoon Nuttymoon requested a review from leopaul36 July 6, 2023 13:23
@Nuttymoon Nuttymoon mentioned this pull request Jul 6, 2023
Merged
@Nuttymoon Nuttymoon merged commit 2ddbdbc into main Jul 6, 2023
@Nuttymoon Nuttymoon deleted the 80-add-validator-vars-propagation branch July 6, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leopaul36 leopaul36 leopaul36 approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validator variables are not propagated properly in avalanche.node.add-validator
2 participants
@Nuttymoon @leopaul36