Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ash_cmd): improve mod security + output #91

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

Nuttymoon
Copy link
Contributor

@Nuttymoon Nuttymoon commented Aug 18, 2023

Linked issues

Dependencies

Changes

  • Add the avalanche_private_key parameter to the ash_cmd module. This parameter is hidden from all Ansible output/logs thanks to the no_log option.
  • Change calls to ash_cmd to use the private key param instead of the environment variable (thus securing the key)
  • Set the ash_cmd task status to changed whenever a transaction was triggered by the command invoked

Additional comments

We will have to change the default ash_cli_version after AshAvalanche/ash-rs#60 is merged.

@Nuttymoon Nuttymoon merged commit 37e4ceb into main Aug 23, 2023
@Nuttymoon Nuttymoon deleted the 79-81-improve-ash_cmd-mod branch August 23, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants