Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area Datatype #10

Open
AsherGlick opened this issue Aug 13, 2021 · 5 comments
Open

Area Datatype #10

AsherGlick opened this issue Aug 13, 2021 · 5 comments
Labels
discussion A discussion around a feature or fix enhancement New feature or request

Comments

@AsherGlick
Copy link
Owner

AsherGlick commented Aug 13, 2021

Areas would be the third datatype on top of Icons and Routes. They are a similar type to Routes but function as enclosed spaces instead of just lines.

This idea was conserved early in the burrito design but thus far the only use cases are for Guacamole (#2) or for being able to have a color-fill in the minimap.

@AsherGlick AsherGlick added enhancement New feature or request discussion A discussion around a feature or fix labels Aug 13, 2021
@coderedart
Copy link
Contributor

was wondering, but can we use the existing trigger_radius of icons/poi as a simple area type? info range and info attributes already act as such, where if you enter within a certain radius, you trigger the info text attribute.

the only reason to have a Area datatype would be to contain non-circular regions like non-uniform polygons. and why would we need such a data type in the first place? to represent heart npc's quest borders?

@AsherGlick
Copy link
Owner Author

This is definitely a possibility if it turns out having support for arbitrary polygons is not worthwhile. That being said I have a small idea of something around hearts where when you walk into a heart a 2D popup appears to tell you what to do in that heart. Not sure if that is the best way to tell people how to do hearts and I was planning on looking at augtyr's heart guides to see if their setup was a better overall idea.

If there is nothing that makes sense for areas beyond "close to this position" then it makes sense to implement trigger radius instead.

@coderedart
Copy link
Contributor

I think tekkit shows a icon with sort of a guide. But I doubt area will be that much more effective than that

@AsherGlick
Copy link
Owner Author

I know position is used in determining when the Sabatha encounter starts, but that is on a pretty narrow bridge so a radius would still probably suffice.

Now that I am sitting on it a little more it probably makes sense to implement trigger_radius as a separate but similar thing from areas, and then leave areas in limbo until a valid use case for them arises. I will update the language spec in #2 .

@dlamkins
Copy link

Coderedart is correct that multiple packs do currently implement it just that way via radius around the heart with the info attribute showing text while in-range. Tekkit's isn't, but ReActif and Teh's trails definitely do.

As an aside, you can use our pack reports to see what attributes are most commonly used by some of the public marker packs.
https://mp-repo.blishhud.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion A discussion around a feature or fix enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants