Fix Fever API not syncing read/starred metadata (#401) #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If anyone wants to try the fix, you can do so by downloading one of the artifacts listed here, unzipping, and installing the APK! |
This was referenced May 16, 2023
Signed-off-by: Mark Bestavros <markbest@bu.edu>
mbestavros
force-pushed
the
fix-fever-sync-read
branch
from
e26f768
to
17d3077
Compare
Ashinch
approved these changes
May 17, 2023
|
Thanks |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to fetch read/unread and starred/un-starred metadata from the remote Fever server and synchronize the local article cache during sync, as discussed in #401. Tested on my local Read You instance against Miniflux, and it works! When I read an article on a different device, it also shows up as read on Read You after sync. Likewise for starring and unstarring.
This is the first serious Kotlin code I've ever written, and I'm sure what I did could probably be done better, but I'm very open to feedback and I'll incorporate any suggestions.
Tagging @Ashinch for review. Resolves #401 and resolves #404.