Add notification permission #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you for review |
|
New release with this fix would be nice. Getting no notifications for about one month now. |
|
Hey, I'm so sorry, I currently don't have much free time, but I will try to
find a way to fix it.
… New release with this fix would be nice. Getting no notifications for
about one month now.
—
Reply to this email directly, view it on GitHub
<#422 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEJHDDLZRUIGAQE4EGJJYGDXKX6WNANCNFSM6AAAAAAYK7DDJY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
This is still an issue. Are you able to make a new release from the latest code? |
|
Hello there. Just discovered this great app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey thanks for the great app!
Small thing - apps targeting API 33 must add declare the notification permission, otherwise they will not be able to post notifications, see the documentation here https://developer.android.com/develop/ui/views/notifications/notification-permission
This PR just adds the permission so users can manually allow the permission, but the app should also request this permission at run-time so the user can accept it too. If you give me a heads up on how you want to do it I can make a PR for that too if you like.
This should fix #407