Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fever): resolve issue with orphaned articles during sync #534

Merged
merged 1 commit into from Jan 18, 2024

Conversation

Ashinch
Copy link
Owner

@Ashinch Ashinch commented Jan 17, 2024

No description provided.

Copy link
Collaborator

@mbestavros mbestavros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ashinch I tested this and it appears to work as expected: I added a new category, it synced, and got added. Then, when I deleted that category, it got deleted from my device. Is that what should be happening? Is the PR supposed to do anything else?

If not, I think you should merge it. Looks like a good change to me.

@Ashinch
Copy link
Owner Author

Ashinch commented Jan 18, 2024

@Ashinch I tested this and it appears to work as expected: I added a new category, it synced, and got added. Then, when I deleted that category, it got deleted from my device. Is that what should be happening? Is the PR supposed to do anything else?

If not, I think you should merge it. Looks like a good change to me.

@mbestavros

As you say, we need to be consistent with the cloud, and the reason I didn't merge it is because I haven't had a chance to test it yet XD

@Ashinch Ashinch merged commit f6fd923 into main Jan 18, 2024
2 checks passed
@Ashinch Ashinch deleted the fix-fever-orphaned branch January 18, 2024 01:37
@Ashinch Ashinch added this to the 0.9.12 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants