Fix mark all as read on Fever API via Miniflux #699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Bestavros <markbest@bu.edu>
mbestavros
changed the title
|
There could be future articles in the feed, and perhaps this method won’t be able to mark them as read. |
|
@Ashinch I realized that this morning 😅 Closing and following up on the linked issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed in #599, Read You's "Mark All As Read" button doesn't work when connected to Miniflux via the Fever API.
It turns out the fix is pretty simple: before, Read You was sending a
before:timestamp ofLong.MAX_VALUE. This produced a truly enormous epoch value, and it's possible Miniflux was just not interpreting it properly.Changing the value to the current Unix time fixes the issue on Miniflux, and should remain functional for all other backends too. (It also just makes more logical sense.)
Tagging @Ashinch @JunkFood02 for review.