[Spec::Linter] Improve frameworks validation logic

Closes CocoaPods#105
Ashton-W · Apr 13, 2014 · 3236705 · 3236705
1 parent 16c4f9e
commit 3236705
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/cocoapods-core/specification/linter.rb b/lib/cocoapods-core/specification/linter.rb
@@ -357,7 +357,7 @@ def _validate_compiler_flags(flags)
       #
       def frameworks_invalid?(frameworks)
         frameworks.any? do |framework|
-          framework_regex = /[^a-zA-Z\d]/
+          framework_regex = /[^\w\-\+]/
           framework =~ framework_regex
         end
       end

diff --git a/spec/specification/linter_spec.rb b/spec/specification/linter_spec.rb
@@ -296,6 +296,13 @@ def message_should_include(*values)
 
       #------------------#
 
+      it 'accepts valid frameworks' do
+        @spec.frameworks = %w(AddressBook Audio-Frameworks)
+        @linter.lint
+        results = @linter.results
+        results.should.be.empty
+      end
+
       it 'checks that frameworks do not end with a .framework extension' do
         @spec.frameworks = %w(AddressBook.framework QuartzCore.framework)
         message_should_include('framework', 'name')
@@ -326,7 +333,6 @@ def message_should_include(*values)
           stdc++.6.0.9
           Geoloqi-$(CONFIGURATION)
         )
-
         @linter.lint
         results = @linter.results
         results.should.be.empty