DRAG-DROP #29
Merged
DRAG-DROP #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstreamDOTh
requested review from
hkedia321,
tstreamDOTh and
thakursaurabh1998
tstreamDOTh
approved these changes
Oct 9, 2018
hkedia321
approved these changes
Oct 9, 2018
thakursaurabh1998
approved these changes
Oct 10, 2018
thakursaurabh1998
suggested changes
Oct 10, 2018
There was a problem hiding this comment.
Adding new note is giving an error. Moreover using arrow functions inside class does not seem to be the right way. @GustavoMantuan You should be including a live working demo. @tstreamDOTh @hkedia321 I request you guys to check it again.
|
@thakursaurabh1998 Strange, did you run npm install again? Cause I added a dependency for uuid to generate ID for cards randomly. I'll check it again for sure. |
|
Yes I did |
|
@thakursaurabh1998 Could you tell me what error are you getting? Nothing is wrong here |
|
@GustavoMantuan Hey can you remove package-lock.json and add it in gitignore as well? |
GustavoMantuan
force-pushed
the
DRAG-DROP
branch
from
d811a9b
to
456e6e5
Compare
tstreamDOTh
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: