Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Laravel 6 #102

Merged
merged 1 commit into from Sep 8, 2019
Merged

Add support for Laravel 6 #102

merged 1 commit into from Sep 8, 2019

Conversation

Lloople
Copy link
Contributor

@Lloople Lloople commented Sep 4, 2019

I know there's already a PR created for this matter, but it needed further changes.

PHPUnit and Testbench need to be updated as well. Also, str_ and array_ helpers were removed from the core so the tests failed with a L6 installation.

@Lloople
Copy link
Contributor Author

Lloople commented Sep 4, 2019

Fixes #100 and replaces #101

@gizburdt
Copy link

gizburdt commented Sep 5, 2019

Awesome! :)

@maguilar92 maguilar92 mentioned this pull request Sep 5, 2019
@maguilar92
Copy link
Collaborator

@Lloople Thanks for collaborate, I will create new branch to merge, review changes and approve as soon as possible.

@maguilar92 maguilar92 mentioned this pull request Sep 5, 2019
@maguilar92 maguilar92 changed the base branch from master to 6.0 September 8, 2019 13:28
@maguilar92 maguilar92 merged commit 6f0cbc9 into Askedio:6.0 Sep 8, 2019
@maguilar92
Copy link
Collaborator

Merged and published on release 6.0.0. @gcphost could you check why is not in packagist the version 6.0.0?

@maguilar92
Copy link
Collaborator

maguilar92 commented Sep 8, 2019

@gcphost I think it has to do with what is deprecated github services.

Captura de pantalla 2019-09-08 a las 18 07 46

@gcphost
Copy link
Contributor

gcphost commented Sep 11, 2019

@maguilar92 thanks and sorry for the delay, did not see the notification.

I have updated the packagist integration and it is now synced.

@maguilar92
Copy link
Collaborator

@gcphost Thanks, I will remove after work in travis support for php 7.1 because laravel works for >= 7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants