Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create EffReplaceCustomFurniture.java #3

Merged
merged 3 commits into from Feb 22, 2024
Merged

Conversation

Marmur2020
Copy link
Contributor

Replaces existing furniture with new furniture
Example: replace custom furniture "ia:my_furniture" at location of player's target block

2024-02-21.11-35-33.mp4

@Marmur2020
Copy link
Contributor Author

I think you'll like it.)

@Asleeepp Asleeepp self-assigned this Feb 21, 2024
@Asleeepp
Copy link
Owner

I like the idea, but I think I'd rather just have a specific "remove custom furniture" effect, rather then a "replace" one.
I'll work on it for the next update.

@Asleeepp Asleeepp closed this Feb 21, 2024
@Marmur2020
Copy link
Contributor Author

I like the idea, but I think I'd rather just have a specific "remove custom furniture" effect, rather then a "replace" one. I'll work on it for the next update.

I don't know, for me this feature made it easier to implement the mechanics of washing gravel to get useful items for stoneblock. That way I had to replace the model with another one. Honestly I wouldn't remove the mechanics and replace with a remove and add method. I may not know what you want to do.

@Asleeepp
Copy link
Owner

I don't know, for me this feature made it easier to implement the mechanics of washing gravel to get useful items for stoneblock. That way I had to replace the model with another one. Honestly I wouldn't remove the mechanics and replace with a remove and add method. I may not know what you want to do.

mmm, I'll add it alongside a remove effect, then.

@Asleeepp Asleeepp reopened this Feb 21, 2024
@Asleeepp Asleeepp merged commit 71fece5 into Asleeepp:master Feb 22, 2024
@Asleeepp Asleeepp added enhancement New feature or request completed labels Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants