otptool: Define value_start in rev_id path
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Please apply: |
Fixes:
```
Traceback (most recent call last):
File "/usr/bin/otptool", line 29, in <module>
tool.run(sys.argv)
File "/usr/lib/python3.11/site-packages/socsec/otptool.py", line 2127, in run
args.func(args)
File "/usr/lib/python3.11/site-packages/socsec/otptool.py", line 2130, in make_otp_image
self.otp.make_otp_image(args.config,
File "/usr/lib/python3.11/site-packages/socsec/otptool.py", line 1335, in make_otp_image
config_region, config_region_ignore = self.make_config_region(
^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/socsec/otptool.py", line 1042, in make_config_region
offset_value = int(value, 16) - value_start
^^^^^^^^^^^
UnboundLocalError: cannot access local variable 'value_start' where it is not associated with a value
```
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Neal Liu neal_liu@aspeedtech.com
amboar
force-pushed
the
value_start-fix
branch
from
99535a0
to
85b886a
Compare
|
I've now added your |
geissonator
pushed a commit
to openbmc/openbmc
that referenced
this pull request
Sep 1, 2023
There's a bug in socsec that prevents the IBM's configuration from successfully building an OTP image. I have got the fix merged upstream: AspeedTech-BMC/socsec#18 However, Aspeed do not plan on doing a release until October: > [ 17:51 ] arj: @troy Lee any chance Neal can tag a new socsec release so we can bump it in OpenBMC and pick up some recent fixes? > [ 18:25 ] Troy Lee: Current schedule is October. https://discord.com/channels/775381525260664832/922871693008068638/1144547174286377062 For now, fix otptool using a recipe patch, in violation of the usual guidelines. I prefer we do this over switching to a "git" version for the recipe as instability with these tools really cannot be tolerated. Change-Id: I65b1992b5479ea257cfa65fd8b3cfc021b7d3dea Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
rfrandse
pushed a commit
to ibm-openbmc/openbmc
that referenced
this pull request
Mar 28, 2024
There's a bug in socsec that prevents the IBM's configuration from successfully building an OTP image. I have got the fix merged upstream: AspeedTech-BMC/socsec#18 However, Aspeed do not plan on doing a release until October: > [ 17:51 ] arj: @troy Lee any chance Neal can tag a new socsec release so we can bump it in OpenBMC and pick up some recent fixes? > [ 18:25 ] Troy Lee: Current schedule is October. https://discord.com/channels/775381525260664832/922871693008068638/1144547174286377062 For now, fix otptool using a recipe patch, in violation of the usual guidelines. I prefer we do this over switching to a "git" version for the recipe as instability with these tools really cannot be tolerated. Change-Id: I65b1992b5479ea257cfa65fd8b3cfc021b7d3dea Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: