fix unit tests #23
Merged
fix unit tests #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intosKai
reviewed
Jan 23, 2024
| if defaultGenesis.Config.PlanckBlock != nil { | ||
| t.Errorf("initial config should have PlanckBlock = nil, but instead PlanckBlock = %v", defaultGenesis.Config.PlanckBlock) | ||
| } | ||
| gHash := params.BSCGenesisHash | ||
| config := defaultGenesis.configOrDefault(gHash) | ||
|
|
||
| if config.ChainID.Cmp(params.MainnetChainConfig.ChainID) != 0 { | ||
| if config.ChainID.Cmp(params.BSCChainConfig.ChainID) != 0 { |
There was a problem hiding this comment.
DefaultETHGenesisBlock() returned Config: params.MainnetChainConfig
But we comparing it with BSCChainConfig
Looks like better to choose one of them to mention
There was a problem hiding this comment.
I copied it from the BSC (link). They use the default ETH mainnet genesis block for this test. With the default BSC mainnet genesis block it doesn't work, test fails.
The test changes the config in the defaultGenesis.configOrDefault(gHash). And this new config is compared.
intosKai
approved these changes
Jan 25, 2024
dmitry123
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.