Sync from internal repo (2024-03-28) (#16)

* fix(sdk/go): add value for best model (#4271)

GitOrigin-RevId: ec5933105be3087e768e6c0e6d0ba6f311635017

* fix(sdk/go): fix missing api key (#4292)

GitOrigin-RevId: dfd3bf62746e889aeaff801cd26d4311eadab327

* refactor(sdk/go): use testify for all tests (#4302)

GitOrigin-RevId: add14f866d3655d36848f3a84dd5b8bfec8830b4

assemblyai.go

@@ -11,7 +11,7 @@ import (
 )
 
 const (
-	version              = "1.4.0"
+	version              = "1.4.1"
 	defaultBaseURLScheme = "https"
 	defaultBaseURLHost   = "api.assemblyai.com"
 	defaultUserAgent     = "assemblyai-go/" + version

assemblyai_test.go

@@ -5,6 +5,8 @@ import (
 	"net/http/httptest"
 	"os"
 	"testing"
+
+	"github.com/stretchr/testify/require"
 )
 
 func setup() (*Client, *http.ServeMux, func()) {
@@ -17,29 +19,12 @@ func setup() (*Client, *http.ServeMux, func()) {
 	return client, handler, server.Close
 }
 
-func testMethod(t *testing.T, r *http.Request, want string) {
-	t.Helper()
-
-	if r.Method != want {
-		t.Errorf("Request method = %v, want = %v", r.Method, want)
-	}
-}
-
-func testQuery(t *testing.T, r *http.Request, want string) {
-	t.Helper()
-
-	if r.URL.RawQuery != want {
-		t.Errorf("Request query = %v, want = %v", r.URL.RawQuery, want)
-	}
-}
-
 func writeFileResponse(t *testing.T, w http.ResponseWriter, filename string) {
 	t.Helper()
 
 	b, err := os.ReadFile(filename)
-	if err != nil {
-		t.Errorf("ReadFile returned error: %v", err)
-	}
+	require.NoError(t, err)
 
-	w.Write(b)
+	_, err = w.Write(b)
+	require.NoError(t, err)
 }

examples/realtime/go.mod

@@ -3,7 +3,7 @@ module github.com/AssemblyAI/DeepLearning/assemblyai/developer_tools/go/examples
 go 1.18
 
 require (
-	github.com/AssemblyAI/assemblyai-go-sdk v1.1.0
+	github.com/AssemblyAI/assemblyai-go-sdk v1.3.0
 	github.com/gordonklaus/portaudio v0.0.0-20230709114228-aafa478834f5
 )
 

go.mod

@@ -4,14 +4,14 @@ go 1.18
 
 require (
 	github.com/cenkalti/backoff v2.2.1+incompatible
-	github.com/google/go-cmp v0.5.9
 	github.com/google/go-querystring v1.1.0
 	github.com/stretchr/testify v1.9.0
 	nhooyr.io/websocket v1.8.7
 )
 
 require (
 	github.com/davecgh/go-spew v1.1.1 // indirect
+	github.com/google/go-cmp v0.5.9 // indirect
 	github.com/klauspost/compress v1.10.3 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect

integration_test.go

@@ -2,38 +2,19 @@ package assemblyai
 
 import (
 	"context"
-	"flag"
-	"fmt"
 	"os"
 	"testing"
-)
 
-var (
-	integration = flag.Bool("integration", false, "Enable integration tests.")
-	apiKey      = os.Getenv("ASSEMBLYAI_API_KEY")
+	"github.com/stretchr/testify/require"
 )
 
-func TestMain(m *testing.M) {
-	flag.Parse()
-
-	if *integration && apiKey == "" {
-		fmt.Println("missing api key")
-		os.Exit(1)
-	}
-
-	os.Exit(m.Run())
-}
-
-func isIntegration(t *testing.T) {
-	t.Helper()
+func TestIntegration(t *testing.T) {
+	t.Parallel()
 
-	if !*integration {
-		t.Skip("skipping integration test...")
+	apiKey := os.Getenv("ASSEMBLYAI_API_KEY")
+	if apiKey == "" {
+		t.Skip("ASSEMBLYAI_API_KEY not set")
 	}
-}
-
-func TestIntegration(t *testing.T) {
-	isIntegration(t)
 
 	client := NewClient(apiKey)
 
@@ -43,45 +24,31 @@ func TestIntegration(t *testing.T) {
 
 	// Transcript
 	f, err := os.Open(path)
-	if err != nil {
-		t.Fatalf("os.Open returned error: %v", err)
-	}
+	require.NoError(t, err)
 	defer f.Close()
 
 	t.Logf("uploading %q...", path)
 
 	audioURL, err := client.Upload(ctx, f)
-	if err != nil {
-		t.Fatalf("Upload returned error: %v", err)
-	}
+	require.NoError(t, err)
 
 	t.Log("uploaded file")
 	t.Logf("submitting %q...", audioURL)
 
 	transcript, err := client.Transcripts.SubmitFromURL(ctx, audioURL, nil)
-	if err != nil {
-		t.Fatalf("Transcripts.Submit returned error: %v", err)
-	}
+	require.NoError(t, err)
 
-	if transcript.Status != TranscriptStatusQueued {
-		t.Fatalf("transcript.Status = %v, want %v", transcript.Status, err)
-	}
+	require.Equal(t, TranscriptStatusQueued, transcript.Status)
 
 	t.Log("submitted transcription")
 	t.Log("waiting for transcription...")
 
 	transcript, err = client.Transcripts.Wait(ctx, ToString(transcript.ID))
-	if err != nil {
-		t.Fatalf("Transcripts.Wait returned error: %v", err)
-	}
+	require.NoError(t, err)
 
-	if transcript.Status != TranscriptStatusCompleted {
-		t.Errorf("transcript.Status = %v, want %v", transcript.Status, err)
-	}
+	require.Equal(t, TranscriptStatusCompleted, transcript.Status)
 
-	if *transcript.Text == "" {
-		t.Errorf("transcript is missing text")
-	}
+	require.NotEmpty(t, *transcript.Text)
 
 	t.Log("completed transcription")
 	t.Logf("transcript.Text = %v", ToString(transcript.Text))
@@ -95,9 +62,7 @@ func TestIntegration(t *testing.T) {
 			TranscriptIDs: []string{ToString(transcript.ID)},
 		},
 	})
-	if err != nil {
-		t.Fatalf("LeMUR.Summarize returned error: %v", err)
-	}
+	require.NoError(t, err)
 
 	t.Logf("LeMUR.Summarize = %v", ToString(response.Response))
 }