Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stderr for console.{warn,error}() #1

Merged
merged 2 commits into from May 21, 2023
Merged

Use stderr for console.{warn,error}() #1

merged 2 commits into from May 21, 2023

Conversation

CountBleck
Copy link
Member

This change just makes sense.

@CountBleck
Add version field to WASI options for Node v20 compatibility
4bf1fc1 
Although Node v20 is not LTS, this change will be useful when it does
become LTS.
@CountBleck
Use stderr for console.{warn,error}()
4472e6c 
Node.js has the same behavior (and it makes sense). Now, all functions
use the correct stream.

Fixes AssemblyScript/assemblyscript#2585.
@CountBleck CountBleck requested a review from dcodeIO May 21, 2023 21:35
dcodeIO
dcodeIO approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly checked what Node.js does, and it seems to also pipe these to stderr. Makes sense to me as proposed :)

@dcodeIO dcodeIO merged commit 4399cff into AssemblyScript:main May 21, 2023
1 check passed
@CountBleck CountBleck deleted the use-stderr branch May 22, 2023 01:26
@mattjohnsonpint
Copy link

mattjohnsonpint commented Mar 6, 2024 •
edited

Looks like this has not been released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@CountBleck @mattjohnsonpint @dcodeIO