Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deepanshutr/queries #100

Merged
merged 4 commits into from
May 22, 2024
Merged

Deepanshutr/queries #100

merged 4 commits into from
May 22, 2024

Conversation

deepanshutr
Copy link
Member

No description provided.

The test methods for key addition and signing have been updated. The key addition test is updated to use multisig and secp256k1 keys, providing a more complex and realistic test scenario. The signing method test has been updated to use legacytx instead of authTypes for generating fees and standard transactions, aligning with the updated cosmos-sdk.
… the 'request_test.go' file. This change impacts the 'TestFee' and 'TestStdTx' functions where authTypes has been replaced with legacytx. The commit ensures that the application uses the correct library for these functions.
The changes included in this commit primarily involve the removal of the unnecessary sdkAddress variable and the redefinition of StdTx in the sign handler's test. This clean-up simplifies the code and enhances readability, whilst maintaining the original functionality of the test.
Copy link
Member Author

@deepanshutr deepanshutr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self reviewed

Signed-off-by: Deepanshu Tripathi <deepanshutr@gmail.com>
@deepanshutr deepanshutr merged commit 01e1137 into master May 22, 2024
0 of 3 checks passed
@deepanshutr deepanshutr deleted the deepanshutr/queries branch May 22, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant