Redo font previewer #1249
Redo font previewer #1249
Conversation
|
Thank you for the contribution. I can't review it right now, but I'll get to it as soon as I can. |
| } | ||
| } | ||
|
|
||
| private static string TryDecode(IUnityObjectBase asset, out byte[] data, out string? fileName, out string? mimeType) |
There was a problem hiding this comment.
Methods with this design pattern should always have a boolean return type.
There was a problem hiding this comment.
And this part is similar to the code:
AssetRipper/Source/AssetRipper.GUI.Web/Pages/Assets/AudioTab.cs
Lines 39 to 46 in 6771232
There was a problem hiding this comment.
That code doesn't have any out parameters, which makes it different. In this case, we want a Boolean return. The current return can be made into another out parameter.
| public override string DisplayName => Localization.AssetTabFont; | ||
|
|
||
| public override string HtmlName => "font"; | ||
|
|
||
| public override bool Enabled => Data.Length > 0; | ||
| public override bool Enabled => !string.IsNullOrEmpty(Source); |
There was a problem hiding this comment.
I just want it keep the same structure as
There was a problem hiding this comment.
My intuition says that the previous version is more future-proof. I foresee Source being removed in some way when this becomes asynchronous.
#932