New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional execution on precompile #122
Closed
freerobby
wants to merge
3
commits into
AssetSync:master
from
shareaholic:optional_execution_on_precompile
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,22 @@ | ||
namespace :assets do | ||
desc "Synchronize assets to S3" | ||
task :sync => :environment do | ||
AssetSync.sync | ||
end | ||
end | ||
|
||
if Rake::Task.task_defined?("assets:precompile:nondigest") | ||
Rake::Task["assets:precompile:nondigest"].enhance do | ||
AssetSync.sync | ||
# Conditional execution needs to be inside the enhance block because the enhance block | ||
# will get executed before yaml or Rails initializers. | ||
Rake::Task["assets:sync"].invoke if defined?(AssetSync) && AssetSync.config.run_on_precompile | ||
end | ||
else | ||
Rake::Task["assets:precompile"].enhance do | ||
# rails 3.1.1 will clear out Rails.application.config if the env vars | ||
# RAILS_GROUP and RAILS_ENV are not defined. We need to reload the | ||
# assets environment in this case. | ||
# Rake::Task["assets:environment"].invoke if Rake::Task.task_defined?("assets:environment") | ||
AssetSync.sync | ||
Rake::Task["assets:sync"].invoke if defined?(AssetSync) && AssetSync.config.run_on_precompile | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This option makes sense, but shouldn't it default to running on precompile, as existing users expect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@turadg It does default to running on precompile; if that
run_on_precompile: false
line is not present, it will run. I added it to this spec yaml file to test that it does not run when disabled. See lib/asset_sync/config.rb, line 54 for the default setting.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, sorry I didn't notice this asset_sync.yml was part of a test.