Enable concurrent (threaded) uploading of files #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 till the cows come home |
|
👍 |
|
For what it's worth, it looks like a couple of the configured builds (ruby 1.9.2 with Rails 3.1 and 3.2) are failing to build nokogiri on TravisCI. Also the specs timeout on the jruby build and I didn't test this with jruby, so I'm really not sure if maybe it behaves strangely with that ruby. |
| @@ -59,6 +61,7 @@ def initialize | |||
| self.enabled = true | |||
| self.run_on_precompile = true | |||
| self.cdn_distribution_id = nil | |||
| self.concurrent_uploads = true | |||
|
It seems to me that all concurrency-related code should be extracted instead of intermingled with conditionals. |
|
👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploading assets can take more than a few minutes for sufficiently large legacy apps (like the one I work on).
When testing this out locally, I tried with an entirely empty bucket, and our compiled assets is ~40mb. With the threaded uploads, it took about 1 minute. After emptying out the bucket and trying again without threads, it took about 30 minutes.
This can be a bit more taxing on system resources, so I built this feature so that it could be turned off with a config setting.